Followup to Bug 1311515 - include information on whether system is at risk of bug 1296630 in the update ping. r=felipc, a=gchang
authorRobert Strong <robert.bugzilla@gmail.com>
Mon, 31 Oct 2016 19:24:37 -0700
changeset 356383 d9ce0a0617634b3d5d8fec265a394e4128df84c2
parent 356382 e1bb38b933fb8e0ed9fefa409427fc2214b3eef0
child 356384 831199d4a5cb99a09abaa98ebfa48a6ea7e366ba
push id6570
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:26:13 +0000
treeherdermozilla-beta@f455459b2ae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfelipc, gchang
bugs1311515, 1296630
milestone51.0a2
Followup to Bug 1311515 - include information on whether system is at risk of bug 1296630 in the update ping. r=felipc, a=gchang
browser/extensions/aushelper/bootstrap.js
--- a/browser/extensions/aushelper/bootstrap.js
+++ b/browser/extensions/aushelper/bootstrap.js
@@ -54,33 +54,34 @@ function startup() {
     }
   } catch (e) {
     cpuIDMatch = null;
     Cu.reportError("Error getting CPU indentifier. Exception: " + e);
     TelemetryLog.log("AUSHELPER_CPU_ID_ERROR", [e]);
   }
 
   let microCodeVersions = [0xe, 0x11, 0x12, 0x13, 0x16, 0x18, 0x19];
-  let cpuRevMatch = false;
+  let cpuRevMatch = null;
   try {
     let keyNames = ["Update Revision", "Update Signature"];
     for (let i = 0; i < keyNames.length; ++i) {
       try {
         let regVal = wrk.readBinaryValue(keyNames[i]);
         if (regVal.length == 8) {
           let hexVal = [];
           // We are only inyterested in the highest byte and return the little
           // endian value for it.
           for (let j = 4; j < 8; j++) {
             let c = regVal.charCodeAt(j).toString(16);
             if (c.length == 1) {
               c = "0" + c;
             }
             hexVal.unshift(c);
           }
+          cpuRevMatch = false;
           if (microCodeVersions.indexOf(parseInt(hexVal.join(''))) != -1) {
             cpuRevMatch = true;
           }
           break;
         }
       } catch (e) {
         if (i == keyNames.length - 1) {
           // The registry key name's value was not successfully queried.