Bug 1183828 - Remove 'nsWindow::GetNativeData not implemented for this type' warning. r=roc
authorEric Rahm <erahm@mozilla.com>
Sat, 25 Jul 2015 10:43:27 -0700
changeset 286252 d9518c1bb41d057cb94aa93db8898dddd17b98a0
parent 286251 ddfcd5c87f76700e388f712ecd4825f1d6170775
child 286253 e78c69d59b604c50d19bee733a18a7c48e01f000
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs1183828
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1183828 - Remove 'nsWindow::GetNativeData not implemented for this type' warning. r=roc
widget/PuppetWidget.cpp
--- a/widget/PuppetWidget.cpp
+++ b/widget/PuppetWidget.cpp
@@ -1060,24 +1060,24 @@ PuppetWidget::GetNativeData(uint32_t aDa
   case NS_NATIVE_SHAREABLE_WINDOW: {
     MOZ_ASSERT(mTabChild, "Need TabChild to get the nativeWindow from!");
     mozilla::WindowsHandle nativeData = 0;
     if (mTabChild) {
       mTabChild->SendGetWidgetNativeData(&nativeData);
     }
     return (void*)nativeData;
   }
+  case NS_NATIVE_WIDGET:
+  case NS_NATIVE_DISPLAY:
+    // These types are ignored (see bug 1183828).
+    break;
   case NS_NATIVE_WINDOW:
-  case NS_NATIVE_DISPLAY:
   case NS_NATIVE_PLUGIN_PORT:
   case NS_NATIVE_GRAPHIC:
   case NS_NATIVE_SHELLWIDGET:
-  case NS_NATIVE_WIDGET:
-    NS_WARNING("nsWindow::GetNativeData not implemented for this type");
-    break;
   default:
     NS_WARNING("nsWindow::GetNativeData called with bad value");
     break;
   }
   return nullptr;
 }
 
 nsIntPoint