Bug 1486486 - Remove bogus link override code in about:memory. r=bz
authorNicholas Nethercote <nnethercote@mozilla.com>
Fri, 31 Aug 2018 12:35:44 +1000
changeset 489336 d929a08b7cce07e1a902403cd71328b4a8ac448a
parent 489335 60f2fed43451da188478d6a29672c69776731e3e
child 489337 bea6259e3a50b06d4398559d6eb530e1973981b8
push id9738
push useraciure@mozilla.com
push dateMon, 03 Sep 2018 16:13:51 +0000
treeherdermozilla-beta@f5841408a66c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1486486
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486486 - Remove bogus link override code in about:memory. r=bz It's throwing because things like `about:memory#end0` aren't valid selectors.
toolkit/components/aboutmemory/content/aboutMemory.js
--- a/toolkit/components/aboutmemory/content/aboutMemory.js
+++ b/toolkit/components/aboutmemory/content/aboutMemory.js
@@ -1424,24 +1424,16 @@ function appendProcessAboutMemoryElement
 
   let appendLink = function(aHere, aThere, aArrow) {
     let link = appendElementWithText(aP, "a", "upDownArrow", aArrow);
     link.href = "#" + aThere + aN;
     link.id = aHere + aN;
     link.title = "Go to the " + aThere + " of " + aProcess;
     link.style = "text-decoration: none";
 
-    // This jumps to the anchor without the page location getting the anchor
-    // name tacked onto its end, which is what happens with a vanilla link.
-    link.addEventListener("click", function(event) {
-      document.documentElement.scrollTop =
-        document.querySelector(event.target.href).offsetTop;
-      event.preventDefault();
-    });
-
     // This gives nice spacing when we copy and paste.
     appendElementWithText(aP, "span", "", "\n");
   };
 
   appendElementWithText(aP, "h1", "", aProcess);
   appendLink("start", "end", kDownwardsArrow);
 
   // We'll fill this in later.