Bug 1188150 - Move ContainerParser dtor to implementation. r=jya
authorRalph Giles <giles@mozilla.com>
Wed, 22 Jul 2015 14:58:19 -0700
changeset 287196 d7ee5d8841d0f0e039a8cc87e0a203cd80f46189
parent 287195 a402fa89a7287e8dd8bce15e7c773153f540295a
child 287197 6b8bc93d561b574770dfc6b1ce6ae5836ffc441d
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1188150
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1188150 - Move ContainerParser dtor to implementation. r=jya This blocks inlining so callers don't have to include SourceBufferResource.h &c. Intended to simplify unit tests.
dom/media/mediasource/ContainerParser.cpp
dom/media/mediasource/ContainerParser.h
--- a/dom/media/mediasource/ContainerParser.cpp
+++ b/dom/media/mediasource/ContainerParser.cpp
@@ -34,16 +34,18 @@ extern PRLogModuleInfo* GetMediaSourceSa
 namespace mozilla {
 
 ContainerParser::ContainerParser(const nsACString& aType)
   : mHasInitData(false)
   , mType(aType)
 {
 }
 
+ContainerParser::~ContainerParser() = default;
+
 bool
 ContainerParser::IsInitSegmentPresent(MediaByteBuffer* aData)
 {
   MSE_DEBUG(ContainerParser, "aLength=%u [%x%x%x%x]",
             aData->Length(),
             aData->Length() > 0 ? (*aData)[0] : 0,
             aData->Length() > 1 ? (*aData)[1] : 0,
             aData->Length() > 2 ? (*aData)[2] : 0,
--- a/dom/media/mediasource/ContainerParser.h
+++ b/dom/media/mediasource/ContainerParser.h
@@ -14,17 +14,17 @@
 namespace mozilla {
 
 class MediaByteBuffer;
 class SourceBufferResource;
 
 class ContainerParser {
 public:
   explicit ContainerParser(const nsACString& aType);
-  virtual ~ContainerParser() = default;
+  virtual ~ContainerParser();
 
   // Return true if aData starts with an initialization segment.
   // The base implementation exists only for debug logging and is expected
   // to be called first from the overriding implementation.
   virtual bool IsInitSegmentPresent(MediaByteBuffer* aData);
 
   // Return true if aData starts with a media segment.
   // The base implementation exists only for debug logging and is expected