Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r=gps,maja_zf
authorSyd Polk <spolk@mozilla.com>
Wed, 24 Feb 2016 14:34:54 -0600
changeset 321962 d78875efa55acb8f8849336e264bee955ce6a460
parent 321961 ead11416e86791968d7b845f902e40a24cd5acd8
child 321963 a90066c54f7cf0755a8c2982ddf4279ebba4b1c4
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps, maja_zf
bugs1250641
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r=gps,maja_zf MozReview-Commit-ID: JxXPjISZDZ0
dom/media/test/external/mach_commands.py
--- a/dom/media/test/external/mach_commands.py
+++ b/dom/media/test/external/mach_commands.py
@@ -29,25 +29,22 @@ def run_external_media_test(tests, testt
         MediaTestRunner,
         mn_cli,
     )
 
     from mozlog.structured import commandline
 
     parser = MediaTestArguments()
     commandline.add_logging_group(parser)
-    args = parser.parse_args()
 
     if not tests:
         tests = [os.path.join(topsrcdir,
                  'dom/media/test/external/external_media_tests/manifest.ini')]
-    args.tests = tests
 
-    if not args.binary:
-        args.binary = kwargs['binary']
+    args = parser.parse_args(args=tests)
 
     for k, v in kwargs.iteritems():
         setattr(args, k, v)
 
     parser.verify_usage(args)
 
     args.logger = commandline.setup_logging("Firefox External Media Tests",
                                             args,