Bug 1465457 - Remove assertion in nsChromeRegistryContent::IsLocaleRTL requiring "global" package r=NeilDeakin
authorBrian Grinstead <bgrinstead@mozilla.com>
Tue, 26 Feb 2019 17:13:48 +0000
changeset 519115 d7779ef1fa2f2941508e094ca652f017e448786a
parent 519114 ed020882a3184d96905bae0100d16a96b9cbcf8f
child 519116 de46aec7227eec05b75c9ed959cf9c5f0ef6a829
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersNeilDeakin
bugs1465457
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1465457 - Remove assertion in nsChromeRegistryContent::IsLocaleRTL requiring "global" package r=NeilDeakin We are running certain xul reftests in the content process registered in chrome://reftest, and it's OK for them to call this function (which is triggered at end of XUL doc loading). Differential Revision: https://phabricator.services.mozilla.com/D21220
chrome/nsChromeRegistryContent.cpp
--- a/chrome/nsChromeRegistryContent.cpp
+++ b/chrome/nsChromeRegistryContent.cpp
@@ -165,20 +165,16 @@ nsChromeRegistryContent::CheckForOSAcces
 }
 
 NS_IMETHODIMP
 nsChromeRegistryContent::CheckForNewChrome() { CONTENT_NOT_IMPLEMENTED(); }
 
 NS_IMETHODIMP
 nsChromeRegistryContent::IsLocaleRTL(const nsACString& aPackage,
                                      bool* aResult) {
-  if (aPackage != nsDependentCString("global")) {
-    NS_ERROR("Packages other than global unavailable");
-    return NS_ERROR_NOT_AVAILABLE;
-  }
   *aResult = GetDirectionForLocale(mLocale);
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsChromeRegistryContent::GetSelectedLocale(const nsACString& aPackage,
                                            bool aAsBCP47, nsACString& aLocale) {
   if (aPackage != nsDependentCString("global")) {