Bug 1476475 - Disable c++98-compat warnings for clang-cl. r=froydnj
☠☠ backed out by 49ae27b76bec ☠ ☠
authorXidorn Quan <me@upsuper.org>
Wed, 18 Jul 2018 11:59:01 +1000
changeset 482138 d752b1eb89febc5baacb19575aa2a3be9639d2f0
parent 482137 1de7861347105883b5dbe52e9cf75f5fe8c048ca
child 482139 b2d1139d20afbea3ad5f0dde5c697e419ff2bc56
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1476475
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476475 - Disable c++98-compat warnings for clang-cl. r=froydnj MozReview-Commit-ID: FOrkf5NgUIL
js/src/old-configure.in
old-configure.in
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -794,16 +794,18 @@ case "$target" in
             # which clang-cl doesn't understand.
             CXXFLAGS="$CXXFLAGS -Wno-ignored-attributes"
             # __attribute__((unused)) really means "might be unused" and
             # we use it to avoid warnings about things that are unused
             # in some compilation units, but used in many others.  This
             # warning insists on complaining about the latter case, which
             # is annoying, and rather noisy.
             CXXFLAGS="$CXXFLAGS -Wno-used-but-marked-unused"
+            # We don't worry about backward-compat with C++98.
+            CXXFLAGS="$CXXFLAGS -Wno-c++98-compat -Wno-c++98-compat-pedantic"
         fi
         # make 'foo == bar;' error out
         CFLAGS="$CFLAGS -we4553"
         CXXFLAGS="$CXXFLAGS -we4553"
         LIBS="$LIBS kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib"
         MOZ_DEBUG_LDFLAGS='-DEBUG -DEBUGTYPE:CV'
         WARNINGS_AS_ERRORS='-WX'
         MOZ_OPTIMIZE_FLAGS="-O2"
--- a/old-configure.in
+++ b/old-configure.in
@@ -1025,16 +1025,18 @@ case "$target" in
             # which clang-cl doesn't understand.
             CXXFLAGS="$CXXFLAGS -Wno-ignored-attributes"
             # __attribute__((unused)) really means "might be unused" and
             # we use it to avoid warnings about things that are unused
             # in some compilation units, but used in many others.  This
             # warning insists on complaining about the latter case, which
             # is annoying, and rather noisy.
             CXXFLAGS="$CXXFLAGS -Wno-used-but-marked-unused"
+            # We don't worry about backward-compat with C++98.
+            CXXFLAGS="$CXXFLAGS -Wno-c++98-compat -Wno-c++98-compat-pedantic"
         fi
         # make 'foo == bar;' error out
         CFLAGS="$CFLAGS -we4553"
         CXXFLAGS="$CXXFLAGS -we4553"
         # Silence VS2017 15.5+ TR1 deprecation warnings hit by older gtest versions
         CXXFLAGS="$CXXFLAGS -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING"
         LIBS="$LIBS kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib"
         MOZ_DEBUG_LDFLAGS='-DEBUG -DEBUGTYPE:CV'