Bug 1314537 - Drop comment reference to SharedKeyframeList; r=comment-only, DONTBUILD
authorBrian Birtles <birtles@gmail.com>
Wed, 20 Sep 2017 11:56:00 +0900
changeset 431379 d4f82b73ba6d6959c7bece6026744f0e2d8e2c6b
parent 431378 72b1e768c334d814da7156bb17eee55da766549d
child 431380 46c0aa7327b3a5035e8678def3e2d216c4fb634a
push id7782
push userryanvm@gmail.com
push dateWed, 20 Sep 2017 11:51:24 +0000
treeherdermozilla-beta@4bfb0b8fb6b1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscomment-only, DONTBUILD
bugs1314537
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1314537 - Drop comment reference to SharedKeyframeList; r=comment-only, DONTBUILD This has been dropped from the spec in: https://github.com/w3c/web-animations/commit/17b14a7269c1be263c5525bf42b3892ac80b0938
dom/animation/KeyframeEffectReadOnly.cpp
--- a/dom/animation/KeyframeEffectReadOnly.cpp
+++ b/dom/animation/KeyframeEffectReadOnly.cpp
@@ -901,18 +901,16 @@ KeyframeEffectReadOnly::ConstructKeyfram
                            aSource.mEffectOptions);
   // Copy cumulative change hint. mCumulativeChangeHint should be the same as
   // the source one because both of targets are the same.
   effect->mCumulativeChangeHint = aSource.mCumulativeChangeHint;
 
   // Copy aSource's keyframes and animation properties.
   // Note: We don't call SetKeyframes directly, which might revise the
   //       computed offsets and rebuild the animation properties.
-  // FIXME: Bug 1314537: We have to make sure SharedKeyframeList is handled
-  //        properly.
   effect->mKeyframes = aSource.mKeyframes;
   effect->mProperties = aSource.mProperties;
   return effect.forget();
 }
 
 template<typename StyleType>
 nsTArray<AnimationProperty>
 KeyframeEffectReadOnly::BuildProperties(StyleType* aStyle)