Bug 1530958 - Fix an issue with native groups for unboxed objects. r=jandem
authorBrian Hackett <bhackett1024@gmail.com>
Wed, 06 Mar 2019 08:29:26 +0100
changeset 520473 d33d48a3998ab78902c384c9a6f752fc74b1fa8e
parent 520412 52e2caa87f892d8075d9e1a358d88bdfb9c89af4
child 520474 5cdbf803ecc052cdff722cc0d3d0393af1922660
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1530958
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1530958 - Fix an issue with native groups for unboxed objects. r=jandem
js/src/vm/UnboxedObject.cpp
--- a/js/src/vm/UnboxedObject.cpp
+++ b/js/src/vm/UnboxedObject.cpp
@@ -711,22 +711,16 @@ bool UnboxedLayout::makeNativeGroup(JSCo
       if (!PropagatePropertyTypes(cx, id, group, nativeGroup)) {
         return false;
       }
 
       // If we are OOM we may not be able to propagate properties.
       if (nativeGroup->unknownProperties(sweepNative)) {
         break;
       }
-
-      HeapTypeSet* nativeProperty =
-          nativeGroup->maybeGetProperty(sweepNative, id);
-      if (nativeProperty && nativeProperty->canSetDefinite(i)) {
-        nativeProperty->setDefinite(i);
-      }
     }
   } else {
     // If we skip, though, the new group had better agree.
     MOZ_ASSERT(nativeGroup->unknownProperties(sweepNative));
   }
 
   layout.nativeGroup_ = nativeGroup;
   layout.nativeShape_ = shape;