Bug 1548409 - Use MOZ_DIAGNOSTIC_ASSERT. r=froydnj
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 02 May 2019 13:24:31 +0000
changeset 531092 d3215b8359d3d53a21c193e990a508000ba47597
parent 531091 59dc2743695d817f095bf76acce8de6073b26598
child 531093 f526b92a7a4aa76faa3a14494c86ddddac994ab0
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1548409
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1548409 - Use MOZ_DIAGNOSTIC_ASSERT. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D29587
mfbt/CheckedInt.h
--- a/mfbt/CheckedInt.h
+++ b/mfbt/CheckedInt.h
@@ -527,17 +527,17 @@ class CheckedInt {
   /** Constructs a valid checked integer with initial value 0 */
   constexpr CheckedInt() : mValue(0), mIsValid(true) {
     static_assert(detail::IsSupported<T>::value,
                   "This type is not supported by CheckedInt");
   }
 
   /** @returns the actual value */
   T value() const {
-    MOZ_RELEASE_ASSERT(
+    MOZ_DIAGNOSTIC_ASSERT(
         mIsValid,
         "Invalid checked integer (division by zero or integer overflow)");
     return mValue;
   }
 
   /**
    * @returns true if the checked integer is valid, i.e. is not the result
    * of an invalid operation or of an operation involving an invalid checked