Bug 1252341 - No need to reset mReader in ~MediaDecoderStateMachine() because the destructor will do that. r=bechen.
authorJW Wang <jwwang@mozilla.com>
Tue, 01 Mar 2016 10:47:36 +0800
changeset 322571 d267ea30eb20ef3b835f9d25d81a831c00d15a73
parent 322541 a1800ff23514f93ad5dbdb74ddfa33be9268cf26
child 322572 9d343ae304ece3fa89d2459423da0719407ade00
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbechen
bugs1252341
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1252341 - No need to reset mReader in ~MediaDecoderStateMachine() because the destructor will do that. r=bechen. MozReview-Commit-ID: AmFsE95Ai9A
dom/media/MediaDecoderStateMachine.cpp
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -321,18 +321,16 @@ MediaDecoderStateMachine::MediaDecoderSt
 #endif
 }
 
 MediaDecoderStateMachine::~MediaDecoderStateMachine()
 {
   MOZ_ASSERT(NS_IsMainThread(), "Should be on main thread.");
   MOZ_COUNT_DTOR(MediaDecoderStateMachine);
 
-  mReader = nullptr;
-
 #ifdef XP_WIN
   timeEndPeriod(1);
 #endif
 }
 
 void
 MediaDecoderStateMachine::InitializationTask(MediaDecoder* aDecoder)
 {