Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible. r=nechen
authorMark Banner <standard8@mozilla.com>
Wed, 13 Dec 2017 10:14:37 -0600
changeset 449181 d18fcc606dc798240da66644e0420423510138b0
parent 449180 dac40e5e9cff836eacc24fa55c0bd9b408efe3f7
child 449182 500105d4a63cd6ea2acfdeeff3c841713457559b
push id8527
push userCallek@gmail.com
push dateThu, 11 Jan 2018 21:05:50 +0000
treeherdermozilla-beta@95342d212a7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnechen
bugs1425052
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1425052 - Enable ESLint rule no-undef for as much of mobile/android as possible. r=nechen MozReview-Commit-ID: IKqMxBgsKqt
mobile/android/.eslintrc.js
mobile/android/modules/dbg-browser-actors.js
--- a/mobile/android/.eslintrc.js
+++ b/mobile/android/.eslintrc.js
@@ -12,13 +12,28 @@ module.exports = {
     "no-empty": "off",
     "no-native-reassign": "off",
     "no-nested-ternary": "off",
     "no-new-object": "off",
     "no-octal": "off",
     "no-redeclare": "off",
     "no-useless-call": "off",
     "no-useless-concat": "off",
-    "no-undef": "off",
     "no-unused-vars": "off",
     "object-shorthand": "off",
-  }
+  },
+
+  "overrides": [{
+    files: [
+      // Bug 1425047.
+      "chrome/**",
+      // Bug 1425048.
+      "components/extensions/**",
+      // Bug 1425034.
+      "modules/WebsiteMetadata.jsm",
+      // Bug 1425051.
+      "tests/browser/robocop/**",
+    ],
+    rules: {
+      "no-undef": "off",
+    }
+  }],
 };
--- a/mobile/android/modules/dbg-browser-actors.js
+++ b/mobile/android/modules/dbg-browser-actors.js
@@ -1,13 +1,15 @@
 /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
+/* eslint-env commonjs */
+
 "use strict";
 /**
  * Fennec-specific actors.
  */
 
 const { RootActor } = require("devtools/server/actors/root");
 const { DebuggerServer } = require("devtools/server/main");
 const { BrowserTabList, BrowserAddonList, sendShutdownEvent } =