Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert
authorTing-Yu Lin <tlin@mozilla.com>
Thu, 02 May 2019 21:41:33 +0000
changeset 531237 d077a01ccd637475a32bfe4ae92ea25f2cc84e14
parent 531236 c49960f2ec7b13be989b173d5a76493f6b821fed
child 531238 66c1e6f5276fc3bbf3fa1f0f68f129844aa9dcdc
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1548126
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert Due to the syntax limitation in failures.list, I cannot mark multicol-rule-004.xht as fails with column-span enabled and success with column-span disabled simultaneously. Luckily, we had another copy of it in testing/web-platform/tests/css/css-multicol/multicol-rule-004.xht, We can use it to test with column-span disabled for now. Differential Revision: https://phabricator.services.mozilla.com/D29419
layout/reftests/columns/reftest.list
layout/reftests/w3c-css/failures.list
layout/reftests/w3c-css/received/reftest.list
layout/reftests/w3c-css/submitted/contain/reftest.list
--- a/layout/reftests/columns/reftest.list
+++ b/layout/reftests/columns/reftest.list
@@ -37,8 +37,17 @@ fuzzy-if(OSX,0-32,0-1000) == columnfill-
 fuzzy-if(browserIsRemote&&winWidget,0-142,0-276) == fieldset-columns-001.html fieldset-columns-001-ref.html
 == fieldset-columns-002.html fieldset-columns-002-ref.html
 == dynamic-change-with-overflow-1.html dynamic-change-with-overflow-1-ref.html
 == dynamic-text-indent-1.html dynamic-text-indent-1-ref.html
 == dynamic-text-indent-2.html dynamic-text-indent-2-ref.html
 == break-avoid-line-position-1.html break-avoid-line-position-1-ref.html
 pref(layout.css.column-span.enabled,true) == column-span-bidi-1.html column-span-bidi-1-ref.html
 pref(layout.css.column-span.enabled,true) == first-line-first-letter.html first-line-first-letter-ref.html
+
+# The following lines are duplicates of other lines from further up in this
+# manifest. They're listed again here so we can re-run these tests with
+# column-span enabled. These lines can be removed once the pref becomes
+# default-enabled (Bug 1426010).
+default-preferences pref(layout.css.column-span.enabled,true)
+fails == min-width-2.html min-width-2-ref.html # Bug 1548100
+fails == column-balancing-nested-001.html column-balancing-nested-001-ref.html # Bug 1548118
+default-preferences
--- a/layout/reftests/w3c-css/failures.list
+++ b/layout/reftests/w3c-css/failures.list
@@ -253,16 +253,18 @@ fuzzy(0-225,0-2529) css-multicol/multico
 fuzzy(0-225,0-2529) css-multicol/multicol-nested-margin-005.xht
 fuzzy(0-135,0-142) css-multicol/multicol-overflow-000.xht
 fuzzy(0-204,0-1844) fuzzy-if(skiaContent,0-208,0-1844) css-multicol/multicol-overflowing-001.xht
 fuzzy-if(OSX,0-61,0-2) fuzzy-if(skiaContent,0-64,0-2) css-multicol/multicol-reduce-000.xht
 fuzzy-if(OSX,0-11,0-20) css-multicol/multicol-rule-000.xht
 fuzzy(0-135,0-1584) css-multicol/multicol-rule-001.xht
 fails-if(!OSX) random-if(OSX) css-multicol/multicol-rule-002.xht
 css-multicol/multicol-rule-003.xht
+# Bug 1548100
+pref(layout.css.column-span.enabled,true) fails css-multicol/multicol-rule-004.xht
 css-multicol/multicol-rule-color-001.xht
 fuzzy(0-106,0-354) css-multicol/multicol-rule-dashed-000.xht
 fuzzy(0-106,0-354) css-multicol/multicol-rule-dotted-000.xht
 fuzzy(0-106,0-354) css-multicol/multicol-rule-double-000.xht
 css-multicol/multicol-rule-fraction-001.xht
 css-multicol/multicol-rule-fraction-002.xht
 fuzzy-if(OSX||winWidget||Android,0-113,0-792) css-multicol/multicol-rule-fraction-003.xht
 fuzzy(0-127,0-500) css-multicol/multicol-rule-groove-000.xht
--- a/layout/reftests/w3c-css/received/reftest.list
+++ b/layout/reftests/w3c-css/received/reftest.list
@@ -120,17 +120,17 @@ fuzzy(0-225,0-2529) == css-multicol/mult
 fuzzy(0-225,0-2529) == css-multicol/multicol-nested-margin-005.xht css-multicol/multicol-nested-margin-004-ref.xht
 fuzzy(0-135,0-142) == css-multicol/multicol-overflow-000.xht css-multicol/multicol-overflow-000-ref.xht
 fuzzy(0-204,0-1844) fuzzy-if(skiaContent,0-208,0-1844) == css-multicol/multicol-overflowing-001.xht css-multicol/multicol-overflowing-001-ref.xht
 fuzzy-if(OSX,0-61,0-2) fuzzy-if(skiaContent,0-64,0-2) == css-multicol/multicol-reduce-000.xht css-multicol/multicol-reduce-000-ref.xht
 fuzzy-if(OSX,0-11,0-20) == css-multicol/multicol-rule-000.xht css-multicol/multicol-rule-000-ref.xht
 fuzzy(0-135,0-1584) == css-multicol/multicol-rule-001.xht css-multicol/multicol-rule-001-ref.xht
 fails-if(!OSX) random-if(OSX) == css-multicol/multicol-rule-002.xht css-multicol/multicol-rule-ref.xht
 == css-multicol/multicol-rule-003.xht css-multicol/multicol-rule-003-ref.xht
-== css-multicol/multicol-rule-004.xht css-multicol/multicol-rule-004-ref.xht
+pref(layout.css.column-span.enabled,true) fails == css-multicol/multicol-rule-004.xht css-multicol/multicol-rule-004-ref.xht
 == css-multicol/multicol-rule-color-001.xht css-multicol/multicol-rule-color-001-ref.xht
 == css-multicol/multicol-rule-color-inherit-001.xht css-multicol/multicol-rule-color-inherit-001-ref.xht
 == css-multicol/multicol-rule-color-inherit-002.xht css-multicol/multicol-rule-color-inherit-001-ref.xht
 fuzzy(0-106,0-354) == css-multicol/multicol-rule-dashed-000.xht css-multicol/multicol-rule-dashed-000-ref.xht
 fuzzy(0-106,0-354) == css-multicol/multicol-rule-dotted-000.xht css-multicol/multicol-rule-dotted-000-ref.xht
 fuzzy(0-106,0-354) == css-multicol/multicol-rule-double-000.xht css-multicol/multicol-rule-double-000-ref.xht
 == css-multicol/multicol-rule-fraction-001.xht css-multicol/multicol-rule-fraction-001-ref.xht
 == css-multicol/multicol-rule-fraction-002.xht css-multicol/multicol-rule-fraction-002-ref.xht
--- a/layout/reftests/w3c-css/submitted/contain/reftest.list
+++ b/layout/reftests/w3c-css/submitted/contain/reftest.list
@@ -44,8 +44,17 @@ fuzzy-if(webrender&&winWidget,0-24,0-2) 
 == contain-layout-containing-block-fixed-001.html contain-paint-containing-block-fixed-001-ref.html
 == contain-layout-containing-block-absolute-001.html contain-paint-containing-block-absolute-001-ref.html
 == contain-layout-ignored-cases-ib-split-001.html contain-layout-ignored-cases-ib-split-001-ref.html
 == contain-layout-ignored-cases-no-principal-box-001.html contain-paint-ignored-cases-no-principal-box-001-ref.html
 == contain-layout-ignored-cases-no-principal-box-002.html contain-layout-ignored-cases-no-principal-box-002-ref.html
 == contain-layout-ignored-cases-no-principal-box-003.html contain-layout-ignored-cases-no-principal-box-003-ref.html
 == contain-layout-suppress-baseline-001.html contain-layout-suppress-baseline-001-ref.html
 fails == contain-layout-suppress-baseline-002.html contain-layout-suppress-baseline-002-ref.html # bug 1508441
+
+# The following lines are duplicates of other lines from further up in this
+# manifest. They're listed again here so we can re-run these tests with
+# column-span enabled. These lines can be removed once the pref becomes
+# default-enabled (Bug 1426010).
+default-preferences pref(layout.css.column-span.enabled,true)
+fails == contain-size-multicol-002.html contain-size-multicol-002-ref.html # Bug 1494100
+fails == contain-size-multicol-003.html contain-size-multicol-003-ref.html # Bug 1494100
+default-preferences