Bug 843433: Annotate CloseFileRunnable as MOZ_FINAL to avoid -Wdelete-non-virtual-dtor build warnings. r=ehsan
authorDaniel Holbert <dholbert@cs.stanford.edu>
Wed, 20 Feb 2013 18:52:44 -0800
changeset 132903 cff90661f8cae50ebac52d218b6bacf8f2382fb4
parent 132902 8018f929ccd7fcfaeee3c11b8d85dbf5d777e2ad
child 132904 534b246aa51be8af0d263ef73b0715d6848e0103
push id2452
push userlsblakk@mozilla.com
push dateMon, 13 May 2013 16:59:38 +0000
treeherdermozilla-beta@d4b152d29d8d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs843433
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 843433: Annotate CloseFileRunnable as MOZ_FINAL to avoid -Wdelete-non-virtual-dtor build warnings. r=ehsan
ipc/glue/FileDescriptorUtils.h
--- a/ipc/glue/FileDescriptorUtils.h
+++ b/ipc/glue/FileDescriptorUtils.h
@@ -1,26 +1,27 @@
 
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef mozilla_ipc_FileDescriptorUtils_h
 #define mozilla_ipc_FileDescriptorUtils_h
 
+#include "mozilla/Attributes.h"
 #include "mozilla/ipc/FileDescriptor.h"
 #include "nsIRunnable.h"
 
 namespace mozilla {
 namespace ipc {
 
 // When Dispatch() is called (from main thread) this class arranges to close the
 // provided FileDescriptor on one of the socket transport service threads (to
 // avoid main thread I/O).
-class CloseFileRunnable : public nsIRunnable
+class CloseFileRunnable MOZ_FINAL : public nsIRunnable
 {
   typedef mozilla::ipc::FileDescriptor FileDescriptor;
 
   FileDescriptor mFileDescriptor;
 
 public:
   CloseFileRunnable(const FileDescriptor& aFileDescriptor)
 #ifdef DEBUG