Backed out changeset 40c5d3600d35 (bug 1455737) for breaking DownloadHistoryList. a=backout
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Sat, 21 Apr 2018 11:12:55 +0100
changeset 468477 cf89da716c0b74286e13ed7ca6ef704a5372afa9
parent 468476 046d0e259116679e2c4908cfa288e774dcddbf07
child 468478 33a23441508ad8544db9c4308b7b74b83319ac2f
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1455737
milestone61.0a1
backs out40c5d3600d35e2d3df7a4f2ab75c64688ee7dc6d
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 40c5d3600d35 (bug 1455737) for breaking DownloadHistoryList. a=backout
toolkit/components/downloads/DownloadHistory.jsm
--- a/toolkit/components/downloads/DownloadHistory.jsm
+++ b/toolkit/components/downloads/DownloadHistory.jsm
@@ -450,27 +450,16 @@ this.DownloadHistoryList.prototype = {
     if (this._result) {
       this._result.root.containerOpen = true;
       PlacesUtils.annotations.addObserver(this);
     }
   },
   _result: null,
 
   /**
-   * Remove the view that belongs to this list via DownloadList's removeView. In
-   * addition, delete the result object to ensure there are no memory leaks.
-   */
-  removeView(aView) {
-    DownloadList.prototype.removeView.call(this, aView);
-
-    // Clean up any active results that might still be observing. See bug 1455737
-    this.result = null;
-  },
-
-  /**
    * Index of the first slot that contains a session download. This is equal to
    * the length of the list when there are no session downloads.
    */
   _firstSessionSlotIndex: 0,
 
   _insertSlot({ slot, index, slotsForUrl }) {
     // Add the slot to the ordered array.
     this._slots.splice(index, 0, slot);