Bug 1470504 - Remove the assertion in ScrollMetadata::SetUsesContainerScrolling(). r=kats
authorBotond Ballo <botond@mozilla.com>
Wed, 26 Sep 2018 19:17:54 -0400
changeset 495306 cf3a63af2da7a4a855afb8f31e3a68bcd9f2e34e
parent 495305 21b67d2084a65be59d8cfd0b495276bf47b5f899
child 495307 a02b46f1567ed9dad5c294b862c9c5ec6d48bea8
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats
bugs1470504
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1470504 - Remove the assertion in ScrollMetadata::SetUsesContainerScrolling(). r=kats The assertion is not serving much purpose. Now that container scrolling is a Live pref, checking it on the compositor side is racy if the pref is flipped, and on the content side it's clear from the code that it will only be set to true if the pref is turned on. Differential Revision: https://phabricator.services.mozilla.com/D7339
gfx/layers/FrameMetrics.cpp
--- a/gfx/layers/FrameMetrics.cpp
+++ b/gfx/layers/FrameMetrics.cpp
@@ -75,17 +75,16 @@ FrameMetrics::KeepLayoutViewportEnclosin
         aLayoutViewport.MoveByY(aVisualViewport.YMost() - aLayoutViewport.YMost());
      }
    }
 }
 
 
 void
 ScrollMetadata::SetUsesContainerScrolling(bool aValue) {
-  MOZ_ASSERT_IF(aValue, gfxPrefs::LayoutUseContainersForRootFrames());
   mUsesContainerScrolling = aValue;
 }
 
 static OverscrollBehavior
 ToOverscrollBehavior(StyleOverscrollBehavior aBehavior)
 {
   switch (aBehavior) {
   case StyleOverscrollBehavior::Auto: