Bug 1270059: ESLint fix r=bustage
authorRandell Jesup <rjesup@jesup.org>
Sat, 26 Jan 2019 12:43:17 -0500
changeset 512688 cec0a3a47cdb
parent 512687 eec1a6963a9c
child 512698 2d2647957a09
push id10566
push userarchaeopteryx@coole-files.de
push dateMon, 28 Jan 2019 12:41:12 +0000
treeherdermozilla-beta@69a3d7c8d04b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1270059
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1270059: ESLint fix r=bustage on a CLOSED TREE
testing/talos/talos/pageloader/chrome/lh_hero.js
--- a/testing/talos/talos/pageloader/chrome/lh_hero.js
+++ b/testing/talos/talos/pageloader/chrome/lh_hero.js
@@ -18,25 +18,22 @@ function _contentHeroHandler(isload) {
     // we want the element 100% visible on the viewport
     var options = {root: null, rootMargin: "0px", threshold: [1]};
     try {
       obs = new content.window.IntersectionObserver(callback, options);
       obs.observe(el);
     } catch (err) {
       sendAsyncMessage("PageLoader:Error", {"msg": err.message});
     }
-  } else {
+  } else if (isload) {
     // If the hero element is added from a settimeout handler, it might not run before 'load'
-    dumpLine("no hero, isload = " + isload);
-    if (isload) {
-      setTimeout(function() {_contentHeroHandler(false); }, 5000);
-    } else {
-      var err = "Could not find a tag with an elmenttiming attr on the page";
-      sendAsyncMessage("PageLoader:Error", {"msg": err});
-    }
+    setTimeout(function() { _contentHeroHandler(false); }, 5000);
+  } else {
+    var err = "Could not find a tag with an elmenttiming attr on the page";
+    sendAsyncMessage("PageLoader:Error", {"msg": err});
   }
   return obs;
 }
 
 function _contentHeroLoadHandler() {
   _contentHeroHandler(true);
 }