Bug 1637783 - Relax SetLoadFlags hard assert to soft assert. r=mattwoodrow, a=pascalc
authorDan Glastonbury <dan.glastonbury@gmail.com>
Wed, 13 May 2020 22:49:01 +0000
changeset 591544 ceba705bb2a7ee0d880910e2ec0c6553ccd84fd5
parent 591543 435111a7b9e5b8cb200497f693e21c3d90196fa3
child 591545 551b03fe57a11bdb2b6936f2e947648347b7abb5
push id13172
push userryanvm@gmail.com
push dateThu, 21 May 2020 18:27:38 +0000
treeherdermozilla-beta@551b03fe57a1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow, pascalc
bugs1637783
milestone77.0
Bug 1637783 - Relax SetLoadFlags hard assert to soft assert. r=mattwoodrow, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D75215
netwerk/ipc/DocumentChannel.cpp
--- a/netwerk/ipc/DocumentChannel.cpp
+++ b/netwerk/ipc/DocumentChannel.cpp
@@ -287,17 +287,19 @@ DocumentChannel::GetTRRMode(nsIRequest::
 }
 
 NS_IMETHODIMP
 DocumentChannel::SetTRRMode(nsIRequest::TRRMode aTRRMode) {
   return SetTRRModeImpl(aTRRMode);
 }
 
 NS_IMETHODIMP DocumentChannel::SetLoadFlags(nsLoadFlags aLoadFlags) {
-  MOZ_CRASH("Don't set flags after creation");
+  NS_ERROR(
+      "DocumentChannel::SetLoadFlags: "
+      "Don't set flags after creation");
   return NS_OK;
 }
 
 NS_IMETHODIMP DocumentChannel::GetOriginalURI(nsIURI** aOriginalURI) {
   nsCOMPtr<nsIURI> originalURI =
       mLoadState->OriginalURI() ? mLoadState->OriginalURI() : mLoadState->URI();
   originalURI.forget(aOriginalURI);
   return NS_OK;