Bug 1533938 - Fix regression from refactor of connect.js page. r=yulia
authorLogan Smyth <loganfsmyth@gmail.com>
Mon, 11 Mar 2019 10:04:22 +0000
changeset 521430 ce4157f3f9673dc0b82f38c94b32a8c27adadbe8
parent 521429 abac6267ab6281e4002d23563253994128f57bc9
child 521431 1d1824ffe05a7f87c2b081c1bf2f0ae1163174be
push id10866
push usernerli@mozilla.com
push dateTue, 12 Mar 2019 18:59:09 +0000
treeherdermozilla-beta@445c24a51727 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyulia
bugs1533938, 1520774
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533938 - Fix regression from refactor of connect.js page. r=yulia Looks like this regressed in a patch for bug 1520774. Differential Revision: https://phabricator.services.mozilla.com/D22811
devtools/client/framework/connect/connect.js
--- a/devtools/client/framework/connect/connect.js
+++ b/devtools/client/framework/connect/connect.js
@@ -200,14 +200,14 @@ function handleConnectionTimeout() {
 }
 
 /**
  * The user clicked on one of the buttons.
  * Opens the toolbox.
  */
 async function openToolbox(target, chrome = false) {
   const hostType = Toolbox.HostType.WINDOW;
-  const toolbox = gDevTools.showToolbox(target, "webconsole", hostType);
+  const toolbox = await gDevTools.showToolbox(target, "webconsole", hostType);
   toolbox.once("destroyed", function() {
     gClient.close();
   });
   window.close();
 }