Bug 1384410 - Fix rotate_to_matrix. r=canaltinova
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Sat, 29 Jul 2017 11:05:32 +0900
changeset 420516 cce87afe39049f1f332ef27a4c02359b41d6ec15
parent 420515 f83e9b59ab26a20e6a981566a7e262a4b7ef39b4
child 420517 1aa98e99c8792d7d76b0069319c51f8f5004690f
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscanaltinova
bugs1384410
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1384410 - Fix rotate_to_matrix. r=canaltinova We used transposed matrices for rotate before this fix. https://www.w3.org/TR/css-transforms-1/#Rotate3dDefined MozReview-Commit-ID: 7LYi74vvIBo
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/web-animations/animation-model/animation-types/property-types.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -620964,17 +620964,17 @@
    "55100f7d505bc8cbc966ced0d1337ed78534a553",
    "testharness"
   ],
   "web-animations/animation-model/animation-types/property-list.js": [
    "31ad7b4aa12e4485f95545b087779cabb56c696c",
    "support"
   ],
   "web-animations/animation-model/animation-types/property-types.js": [
-   "ed8c0c3f297ec6ad93c63d784f2a393659d96d40",
+   "80be6cea9cc4d5986abbdf2823e013b8e5b4bcab",
    "support"
   ],
   "web-animations/animation-model/combining-effects/effect-composition.html": [
    "8ac06085132d822e908d48de4c1109b66323f19f",
    "testharness"
   ],
   "web-animations/animation-model/keyframe-effects/effect-value-context.html": [
    "10d9ee521240475a1729c2facfcea8b50342614e",
--- a/testing/web-platform/tests/web-animations/animation-model/animation-types/property-types.js
+++ b/testing/web-platform/tests/web-animations/animation-model/animation-types/property-types.js
@@ -898,16 +898,26 @@ const transformListType = {
 
       testAnimationSampleMatrices(animation, idlName,
         [{ time: 500,  expected: [ 0.4, 0,   0,   0,
                                    0,   0.4, 0,   0,
                                    0,   0,   1,   0,
                                    0,   0,   0.5, 1] }]);
     }, property + ': mismatched 3D transforms');
 
+    test(function(t) {
+      var idlName = propertyToIDL(property);
+      var target = createTestElement(t, setup);
+      var animation =
+        target.animate({ [idlName]: ['rotateY(60deg)', 'none' ] }, 1000);
+
+      testAnimationSampleMatrices(animation, idlName,
+                   // rotateY(30deg) == rotate3D(0, 1, 0, 30deg)
+        [{ time: 500, expected: rotate3dToMatrix(0, 1, 0, Math.PI / 6) }]);
+    }, property + ': rotateY');
   },
 
   testAddition: function(property, setup) {
     test(function(t) {
       var idlName = propertyToIDL(property);
       var target = createTestElement(t, setup);
       target.style[idlName] = 'translateX(100px)';
       var animation = target.animate({ [idlName]: ['translateX(-200px)',