Bug 1368508 - Log actual and allowed fuzz values when a reftest passes by fuzzy matching. r=dbaron
authorKartikaya Gupta <kgupta@mozilla.com>
Tue, 30 May 2017 16:31:05 -0400
changeset 409515 ca2c5adc69103786df47a74c9f402851ccca0f08
parent 409514 648eadae596481359d38051189444c64fad03192
child 409516 f5bcb4ddb655e64a8c444c1a708ef053f7d07407
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1368508
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1368508 - Log actual and allowed fuzz values when a reftest passes by fuzzy matching. r=dbaron This simply augments the logging in the reftest harness so that if a reftest passes due to fuzzy matching, it reports both the actual fuzz numbers and the maximum allowed fuzz numbers. MozReview-Commit-ID: G356vBRXYUc
layout/tools/reftest/reftest.jsm
--- a/layout/tools/reftest/reftest.jsm
+++ b/layout/tools/reftest/reftest.jsm
@@ -1722,17 +1722,17 @@ function RecordResult(testRunTime, error
             var expected = gURLs[0].expected;
 
             if (maxDifference.value > 0 && maxDifference.value <= gURLs[0].fuzzyMaxDelta &&
                 differences <= gURLs[0].fuzzyMaxPixels) {
                 if (equal) {
                     throw "Inconsistent result from compareCanvases.";
                 }
                 equal = expected == EXPECTED_FUZZY;
-                logger.info("REFTEST fuzzy match");
+                logger.info(`REFTEST fuzzy match (${maxDifference.value}, ${differences}) <= (${gURLs[0].fuzzyMaxDelta}, ${gURLs[0].fuzzyMaxPixels})`);
             }
 
             var failedExtraCheck = gFailedNoPaint || gFailedOpaqueLayer || gFailedAssignedLayer;
 
             // whether the comparison result matches what is in the manifest
             var test_passed = (equal == (gURLs[0].type == TYPE_REFTEST_EQUAL)) && !failedExtraCheck;
 
             output = outputs[expected][test_passed];