Bug 1455143 - Remove code for failing to obtain a hash; r=ted
authorGregory Szorc <gps@mozilla.com>
Wed, 18 Apr 2018 15:36:55 -0700
changeset 468155 c9cbbb881c78d5d928b3a6453c1f46940c6f3758
parent 468154 2bbe78c011d3a4631a3a34b47811564463ab66e5
child 468156 1f1186400490312f53369a838d2fdddd594a8ca9
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1455143
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455143 - Remove code for failing to obtain a hash; r=ted digest_file() should always return something. MozReview-Commit-ID: 6PpSUnxhCcL
build/checksums.py
--- a/build/checksums.py
+++ b/build/checksums.py
@@ -56,20 +56,17 @@ def process_files(files, output_filename
         logger.debug('Overwriting existing checksums file "%s"' %
                      output_filename)
     else:
         logger.debug('Creating a new checksums file "%s"' % output_filename)
     with open(output_filename, 'w+') as output:
         for file in files:
             for digest in digests:
                 hash = digest_file(file, digest)
-                if hash is None:
-                    logger.warn('Unable to generate a hash for %s. ' +
-                                'Skipping.' % file)
-                    continue
+
                 if file.startswith(strip):
                     short_file = file[len(strip):]
                     short_file = short_file.lstrip('/')
                 else:
                     short_file = file
                 print >>output, '%s %s %s %s' % (hash, digest,
                                                  os.path.getsize(file),
                                                  short_file)