Bug 1097128 - Enable compile-time support for vertical writing modes. r=smontagu
authorJonathan Kew <jkew@mozilla.com>
Wed, 19 Nov 2014 11:15:45 +0000
changeset 240803 c9c720eea5b1c3f8eecd5fb20cf696814ce8d64f
parent 240802 40e56f99632b65fa07704b838cc8c3db2f1fe46f
child 240804 ea2d1aa200e425c8fb33c4f79ad436551d0c803e
push id4311
push userraliiev@mozilla.com
push dateMon, 12 Jan 2015 19:37:41 +0000
treeherdermozilla-beta@150c9fed433b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmontagu
bugs1097128
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1097128 - Enable compile-time support for vertical writing modes. r=smontagu
layout/generic/WritingModes.h
--- a/layout/generic/WritingModes.h
+++ b/layout/generic/WritingModes.h
@@ -11,17 +11,22 @@
 
 // If WRITING_MODE_VERTICAL_ENABLED is defined, we will attempt to support
 // the vertical writing-mode values; if it is not defined, then
 // WritingMode.IsVertical() will be hard-coded to return false, allowing
 // many conditional branches to be optimized away while we're in the process
 // of transitioning layout to use writing-mode and logical directions, but
 // not yet ready to ship vertical support.
 
-/* #define WRITING_MODE_VERTICAL_ENABLED 1 */
+// XXX To be removed, and the #ifdef blocks below made unconditional,
+//     once we're confident we can leave it permanently enabled.
+
+#ifndef RELEASE_BUILD
+#define WRITING_MODE_VERTICAL_ENABLED 1
+#endif
 
 // It is the caller's responsibility to operate on logical-coordinate objects
 // with matched writing modes. Failure to do so will be a runtime bug; the
 // compiler can't catch it, but in debug mode, we'll throw an assertion.
 // NOTE that in non-debug builds, a writing mode mismatch error will NOT be
 // detected, yet the results will be nonsense (and may lead to further layout
 // failures). Therefore, it is important to test (and fuzz-test) writing-mode
 // support using debug builds.