Bug 1521404 - Fix apilint warnings about BuildConfig. r=geckoview-reviewers,snorp
authorAgi Sferro <agi@mozilla.com>
Wed, 23 Jan 2019 14:48:12 +0000
changeset 512231 c997411e8d31c1b407712279582fe53fbe2d5f95
parent 512230 64d38928ff5a59fb8214a0ee2472dccd6f16705d
child 512232 0ff1d5547705e9235e8858d6a9c00a37f3da12c7
push id10566
push userarchaeopteryx@coole-files.de
push dateMon, 28 Jan 2019 12:41:12 +0000
treeherdermozilla-beta@69a3d7c8d04b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgeckoview-reviewers, snorp
bugs1521404
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521404 - Fix apilint warnings about BuildConfig. r=geckoview-reviewers,snorp See https://github.com/mozilla-mobile/gradle-apilint/commit/aa9e8a7a2337b3d76951e1bc78c653b51b9be188. Differential Revision: https://phabricator.services.mozilla.com/D17268
build.gradle
mobile/android/geckoview/build.gradle
--- a/build.gradle
+++ b/build.gradle
@@ -82,17 +82,17 @@ buildscript {
     ext.support_library_version = '26.1.0'
     ext.jacoco_version = '0.8.1'
 
     if (gradle.mozconfig.substs.MOZ_ANDROID_GOOGLE_PLAY_SERVICES) {
         ext.google_play_services_version = '15.0.1'
     }
 
     dependencies {
-        classpath 'org.mozilla.apilint:apilint:0.1.6'
+        classpath 'org.mozilla.apilint:apilint:0.1.7'
         classpath 'com.android.tools.build:gradle:3.1.4'
         classpath 'com.getkeepsafe.dexcount:dexcount-gradle-plugin:0.8.2'
         classpath 'org.apache.commons:commons-exec:1.3'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }
 
 // A stream that processes bytes line by line, prepending a tag before sending
--- a/mobile/android/geckoview/build.gradle
+++ b/mobile/android/geckoview/build.gradle
@@ -502,10 +502,11 @@ if (mozconfig.substs.MOZ_JAVA_CODE_COVER
 }
 
 apply plugin: 'org.mozilla.apilint'
 
 apiLint {
     // TODO: Change this to `org` after hiding org.mozilla.gecko
     packageFilter = 'org.mozilla.geckoview'
     changelogFileName = 'src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md'
+    skipClassesRegex = ['^org.mozilla.geckoview.BuildConfig$']
     lintFilters = ['GV']
 }