Bug 1417215 - Prefer prefix ++ operator for non primitive types r=froydnj
authorJean-Luc Bonnafoux <jeanluc.bonnafoux@wanadoo.fr>
Sat, 30 Dec 2017 21:09:58 +0100
changeset 449900 c959ea5adf6acaa072b5d9cd4a0e5770da423fe7
parent 449899 68d4fd90cd47d754c47111166288476d03559bbe
child 449901 c23677250e786ce2cccfc92149c667f65ec37d18
push id8527
push userCallek@gmail.com
push dateThu, 11 Jan 2018 21:05:50 +0000
treeherdermozilla-beta@95342d212a7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1417215
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1417215 - Prefer prefix ++ operator for non primitive types r=froydnj MozReview-Commit-ID: Hjbj0PEjAnf
build/unix/elfhack/elfxx.h
--- a/build/unix/elfhack/elfxx.h
+++ b/build/unix/elfhack/elfxx.h
@@ -624,17 +624,17 @@ public:
     : ElfSection(s, file, parent)
     {
         table.push_back(table_storage(data, shdr.sh_size));
     }
 
     ~ElfStrtab_Section()
     {
         for (std::vector<table_storage>::iterator t = table.begin() + 1;
-             t != table.end(); t++)
+             t != table.end(); ++t)
             delete[] t->buf;
     }
 
     const char *getStr(unsigned int index);
 
     const char *getStr(const char *string);
 
     unsigned int getStrIndex(const char *string);
@@ -671,17 +671,17 @@ inline char Elf::getMachine() {
 inline unsigned int Elf::getSize() {
     ElfSection *section;
     for (section = shdr_section /* It's usually not far from the end */;
         section->getNext() != nullptr; section = section->getNext());
     return section->getOffset() + section->getSize();
 }
 
 inline ElfSegment *ElfSection::getSegmentByType(unsigned int type) {
-    for (std::vector<ElfSegment *>::iterator seg = segments.begin(); seg != segments.end(); seg++)
+    for (std::vector<ElfSegment *>::iterator seg = segments.begin(); seg != segments.end(); ++seg)
         if ((*seg)->getType() == type)
             return *seg;
     return nullptr;
 }
 
 inline void ElfSection::insertInSegments(std::vector<ElfSegment *> &segs) {
     for (std::vector<ElfSegment *>::iterator it = segs.begin(); it != segs.end(); ++it) {
         (*it)->addSection(this);