Backed out changeset b0c79c15c6ff (bug 1363505)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Wed, 31 May 2017 22:59:44 +0200
changeset 409751 c8f21748527b42bdb0bb2d84ca25b0410730072a
parent 409750 61cc994f34d3ac8cf13536e479c864697ad3a2a5
child 409752 f7561f92cf88b59b2397eb5d6600fd3f9eb04699
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1363505
milestone55.0a1
backs outb0c79c15c6ffdadedc4d64fa90a409a0316c8a31
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset b0c79c15c6ff (bug 1363505)
browser/base/content/test/performance/browser.ini
browser/base/content/test/performance/browser_tabswitch_reflows.js
--- a/browser/base/content/test/performance/browser.ini
+++ b/browser/base/content/test/performance/browser.ini
@@ -1,10 +1,9 @@
 [DEFAULT]
 support-files =
   head.js
 [browser_tabclose_grow_reflows.js]
 [browser_tabclose_reflows.js]
 [browser_tabopen_reflows.js]
 [browser_tabopen_squeeze_reflows.js]
-[browser_tabswitch_reflows.js]
 [browser_toolbariconcolor_restyles.js]
 [browser_windowopen_reflows.js]
deleted file mode 100644
--- a/browser/base/content/test/performance/browser_tabswitch_reflows.js
+++ /dev/null
@@ -1,55 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
-   http://creativecommons.org/publicdomain/zero/1.0/ */
-
-"use strict";
-
-/**
- * WHOA THERE: We should never be adding new things to EXPECTED_REFLOWS. This
- * is a whitelist that should slowly go away as we improve the performance of
- * the front-end. Instead of adding more reflows to the whitelist, you should
- * be modifying your code to avoid the reflow.
- *
- * See https://developer.mozilla.org/en-US/Firefox/Performance_best_practices_for_Firefox_fe_engineers
- * for tips on how to do that.
- */
-const EXPECTED_REFLOWS = [
-  [
-    "_adjustFocusAfterTabSwitch@chrome://browser/content/tabbrowser.xml",
-  ],
-];
-
-if (gMultiProcessBrowser) {
-  EXPECTED_REFLOWS.push(
-    [
-      "_adjustFocusAfterTabSwitch@chrome://browser/content/tabbrowser.xml",
-    ]
-  );
-}
-
-/*
- * This test ensures that there are no unexpected
- * uninterruptible reflows when switching between two
- * tabs that are both fully visible.
- */
-add_task(async function() {
-  await ensureNoPreloadedBrowser();
-
-  // Because the tab strip is a scrollable frame, we can't use the
-  // default dirtying function from withReflowObserver and reliably
-  // get reflows for the strip. Instead, we provide a node that's
-  // already in the scrollable frame to dirty - in this case, the
-  // original tab.
-  let origTab = gBrowser.selectedTab;
-
-  let firstSwitchDone = BrowserTestUtils.waitForEvent(window, "TabSwitchDone");
-  let otherTab = await BrowserTestUtils.openNewForegroundTab(gBrowser);
-  await firstSwitchDone;
-
-  await withReflowObserver(async function() {
-    let switchDone = BrowserTestUtils.waitForEvent(window, "TabSwitchDone");
-    gBrowser.selectedTab = origTab;
-    await switchDone;
-  }, EXPECTED_REFLOWS, window, origTab);
-
-  await BrowserTestUtils.removeTab(otherTab);
-});