bug 1471281: build: make asan depend on --help; r=froydnj
authorAndreas Tolfsen <ato@sny.no>
Thu, 06 Sep 2018 16:49:55 +0100
changeset 491414 c8ee11194f694700a00a726e92411637ebed84fe
parent 491413 781af82c435956ea8ff7fe20a487c3bd24d0e44f
child 491415 3a859a6f0720e3841d44721414e2c9f8a099048c
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1471281
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1471281: build: make asan depend on --help; r=froydnj The asan definition needs to depend on --help for the --enable-geckodriver flag to depend on it through geckodriver_default.
build/moz.configure/toolchain.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -1411,18 +1411,18 @@ add_old_configure_assignment('MOZ_LTO_CF
 add_old_configure_assignment('MOZ_LTO_LDFLAGS', lto.ldflags)
 
 # ASAN
 # ==============================================================
 
 js_option('--enable-address-sanitizer', help='Enable Address Sanitizer')
 
 
-@depends_if('--enable-address-sanitizer')
-def asan(value):
+@depends_if('--enable-address-sanitizer', '--help')
+def asan(value, _):
     return True
 
 
 add_old_configure_assignment('MOZ_ASAN', asan)
 
 
 # Security Hardening
 # ==============================================================