Bug 908248 - Intermittent test_tcpserversocket.js. r=jdm
authorTomoaki Konno <tm-konno@kddilabs.jp>
Thu, 24 Oct 2013 02:48:00 +0100
changeset 165763 c8b7c62b143169810362c354691095ec26cd29f3
parent 165762 bad33433e11feff34b1265be39f69765627f172b
child 165764 23eb32b0f555df349cc64f0b58e0e64a0a6d4c13
push id3066
push userakeybl@mozilla.com
push dateMon, 09 Dec 2013 19:58:46 +0000
treeherdermozilla-beta@a31a0dce83aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdm
bugs908248
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 908248 - Intermittent test_tcpserversocket.js. r=jdm
dom/network/tests/unit/test_tcpserversocket.js
--- a/dom/network/tests/unit/test_tcpserversocket.js
+++ b/dom/network/tests/unit/test_tcpserversocket.js
@@ -197,17 +197,17 @@ function connectSock() {
 function openSockInClosingServer() {
   var success = makeSuccessCase('clientnotopen');
   var options = { binaryType: 'arraybuffer' };
   
   sock = TCPSocket.open(
     '127.0.0.1', PORT, options);
 
   sock.onopen = makeFailureCase('open');
-  sock.onerror = success();
+  sock.onerror = success;
 }
 
 /**
  * Test that sending a small amount of data works, and that buffering
  * does not take place for this small amount of data.
  */
 
 function sendDataToServer() {
@@ -295,18 +295,9 @@ add_test(sendDataToServer);
 
 add_test(cleanup);
 
 function run_test() {
   if (!gInChild)
     Services.prefs.setBoolPref('dom.mozTCPSocket.enabled', true);
 
   run_next_test();
-
-  do_timeout(10000, function() {
-    if (server) {
-      server.close();
-    }
-
-    do_throw(
-      "The test should never take this long unless the system is hosed.");
-  });
 }