Bug 1513676 - Twice-reported memory allocations in CacheStorageService code, r=honzab
authorMichal Novotny <michal.novotny>
Tue, 08 Jan 2019 16:38:00 +0200
changeset 510181 c85b59bb06cbe7d00ae56c5f7fb4f727838bc71f
parent 510180 86cbcf2195f9d41aae9560c4028785d95003a86d
child 510182 9663d8100bdb65dda241c578c5279075a6d07c3a
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershonzab
bugs1513676
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1513676 - Twice-reported memory allocations in CacheStorageService code, r=honzab Do not report malloc size of CacheIOThread::mThread, because it can be reported by ThreadsReporter.
netwerk/cache2/CacheIOThread.cpp
--- a/netwerk/cache2/CacheIOThread.cpp
+++ b/netwerk/cache2/CacheIOThread.cpp
@@ -591,17 +591,16 @@ NS_IMETHODIMP CacheIOThread::AfterProces
 
 // Memory reporting
 
 size_t CacheIOThread::SizeOfExcludingThis(
     mozilla::MallocSizeOf mallocSizeOf) const {
   MonitorAutoLock lock(const_cast<CacheIOThread*>(this)->mMonitor);
 
   size_t n = 0;
-  n += mallocSizeOf(mThread);
   for (const auto& event : mEventQueue) {
     n += event.ShallowSizeOfExcludingThis(mallocSizeOf);
     // Events referenced by the queues are arbitrary objects we cannot be sure
     // are reported elsewhere as well as probably not implementing nsISizeOf
     // interface.  Deliberatly omitting them from reporting here.
   }
 
   return n;