Bug 1510478 - Disable clang-formatting for XPTCall stub files. r=Ehsan
authorAndrew McCreight <continuation@gmail.com>
Wed, 28 Nov 2018 21:26:43 +0000
changeset 505028 c67e1875a652439706487664fda9e6c10f2285ed
parent 505027 d53add8e41304d0da346582da8c16fd43c9f174a
child 505029 162db3b0344a7342e41f1ad67946e92ac9cafc2a
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersEhsan
bugs1510478, 1510781
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510478 - Disable clang-formatting for XPTCall stub files. r=Ehsan Many of the inline assembly macros in these files get reformatted poorly by clang-format, so don't format them for now. In followup work, in bug 1510781, hopefully we can write a larger patch to only disable clang-format for the specific macros and then format the rest of the files. The problematic include STUB_ENTRY and STUB_MANGLED_ENTRY. Differential Revision: https://phabricator.services.mozilla.com/D13311
.clang-format-ignore
--- a/.clang-format-ignore
+++ b/.clang-format-ignore
@@ -44,16 +44,21 @@ xpcom/tests/.*
 .*/.*.pb.cc
 
 # Autogenerated file
 gfx/webrender_bindings/webrender_ffi_generated.h
 intl/unicharutil/util/nsUnicodePropertyData.cpp
 intl/unicharutil/util/nsUnicodeScriptCodes.h
 media/mp4parse-rust/mp4parse.h
 
+# The XPTCall stubs files have some inline assembly macros
+# that get reformatted badly. See bug 1510781.
+xpcom/reflect/xptcall/md/win32/.*
+xpcom/reflect/xptcall/md/unix/.*
+
 # Generated from ./tools/rewriting/ThirdPartyPaths.txt
 # awk '{print ""$1".*"}' ./tools/rewriting/ThirdPartyPaths.txt
 browser/components/translation/cld2/.*
 browser/extensions/mortar/ppapi/.*
 db/sqlite3/src/.*
 devtools/client/sourceeditor/codemirror/.*
 devtools/client/sourceeditor/tern/.*
 dom/canvas/test/webgl-conf/checkout/closure-library/.*