Bug 1417442 - P3. Don't enable nv12 surfaces if we failed to parse the version string. r=mattwoodrow, a=sledru
authorJean-Yves Avenard <jyavenard@mozilla.com>
Wed, 15 Nov 2017 23:33:37 +0100
changeset 442422 c645b0914f62
parent 442421 38cedabd74d2
child 442423 e93cdfd48553
push id8203
push userryanvm@gmail.com
push dateWed, 22 Nov 2017 21:05:02 +0000
treeherdermozilla-beta@d55f73f1c890 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow, sledru
bugs1417442
milestone58.0
Bug 1417442 - P3. Don't enable nv12 surfaces if we failed to parse the version string. r=mattwoodrow, a=sledru MozReview-Commit-ID: 1MKtCOO1gcS
dom/media/platforms/wmf/DXVA2Manager.cpp
--- a/dom/media/platforms/wmf/DXVA2Manager.cpp
+++ b/dom/media/platforms/wmf/DXVA2Manager.cpp
@@ -1260,17 +1260,17 @@ DXVA2Manager::IsNV12Supported(uint32_t a
     for (const auto& model : sAMDPreUVD4) {
       if (aDeviceID == model) {
         return false;
       }
     }
     // AMD driver earlier than 21.19.411.0 have bugs in their handling of NV12
     // surfaces.
     uint64_t driverVersion;
-    if (widget::ParseDriverVersion(aDriverVersionString, &driverVersion) &&
+    if (!widget::ParseDriverVersion(aDriverVersionString, &driverVersion) ||
         driverVersion < widget::V(21, 19, 411, 0)) {
       return false;
     }
   } else if (aVendorID == 0x10DE) {
     // NVidia
     for (const auto& model : sNVIDIABrokenNV12) {
       if (aDeviceID == model) {
         return false;