Bug 1251856 - Disable U2F in all releases (fix for 1231681). r=baku a=backout
authorJ.C. Jones <jjones@mozilla.com>
Mon, 29 Feb 2016 09:06:40 -0700
changeset 322636 c5f11d429e6b03db7b7db5b860eb8f1cddf3ae3a
parent 322635 f72ff2a705d01c4fcb2a241b3c9994d331b417b3
child 322637 71fabdbb3567e3d16836fac9daf84f9e6eaf5543
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku, backout
bugs1251856, 1231681
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1251856 - Disable U2F in all releases (fix for 1231681). r=baku a=backout * Pref off the "U2F" interface to blank out the integer constants, and * Disable U2F in all releases. MozReview-Commit-ID: 8HlkaRbg4Qh
dom/tests/mochitest/general/test_interfaces.html
dom/webidl/U2F.webidl
--- a/dom/tests/mochitest/general/test_interfaces.html
+++ b/dom/tests/mochitest/general/test_interfaces.html
@@ -1373,17 +1373,17 @@ var interfaceNamesInGlobalScope =
     {name: "TVProgram", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "TVScanningStateChangedEvent", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "TVSource", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "TVTuner", b2g: true, permission: ["tv"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    {name: "U2F", release: false},
+    {name: "U2F", disabled: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "UDPMessageEvent", b2g: true, permission: ["udp-socket"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "UDPSocket", b2g: true, permission: ["udp-socket"]},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "UIEvent",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "UndoManager",
--- a/dom/webidl/U2F.webidl
+++ b/dom/webidl/U2F.webidl
@@ -63,16 +63,17 @@ dictionary SignResponse {
     // From Error
     ErrorCode? errorCode;
     DOMString? errorMessage;
 };
 
 callback U2FRegisterCallback = void(RegisterResponse response);
 callback U2FSignCallback = void(SignResponse response);
 
+[Pref="security.webauth.u2f"]
 interface U2F {
   // These enumerations are defined in the FIDO U2F Javascript API under the
   // interface "ErrorCode" as constant integers, and also in the U2F.cpp file.
   // Any changes to these must occur in both locations.
   const unsigned short OK = 0;
   const unsigned short OTHER_ERROR = 1;
   const unsigned short BAD_REQUEST = 2;
   const unsigned short CONFIGURATION_UNSUPPORTED = 3;