Bug 1245000 part 2 - Don't ship Animation.ready; r=bz
authorBrian Birtles <birtles@gmail.com>
Fri, 22 Apr 2016 13:41:58 +0900
changeset 332317 c5d652fb84d1af80c93796af3c7cb96ae7999615
parent 332316 e1b99e5251cb9ba6620599a2c1f7e54d00fc413c
child 332318 59aa5395fff1ef5eabc7730f2cd9b35dda1a5387
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1245000
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1245000 part 2 - Don't ship Animation.ready; r=bz Like Animation.finished, this will likely change to a cancelable promise in the future (assuming such things materialize) so we should not ship it for the time being.
dom/webidl/Animation.webidl
--- a/dom/webidl/Animation.webidl
+++ b/dom/webidl/Animation.webidl
@@ -25,17 +25,17 @@ interface Animation : EventTarget {
   [BinaryName="startTimeAsDouble"]
   attribute double? startTime;
   [SetterThrows, BinaryName="currentTimeAsDouble"]
   attribute double? currentTime;
 
            attribute double             playbackRate;
   [BinaryName="playStateFromJS"]
   readonly attribute AnimationPlayState playState;
-  [Throws]
+  [Func="nsDocument::IsWebAnimationsEnabled", Throws]
   readonly attribute Promise<Animation> ready;
   [Func="nsDocument::IsWebAnimationsEnabled", Throws]
   readonly attribute Promise<Animation> finished;
            attribute EventHandler       onfinish;
            attribute EventHandler       oncancel;
   void cancel ();
   [Throws]
   void finish ();