Bug 1060993 - Fix more bad implicit constructors in spellchecker; r=smaug
authorEhsan Akhgari <ehsan@mozilla.com>
Sun, 31 Aug 2014 21:09:33 -0400
changeset 224466 c56a4903179ee09ddc5e64664685e1af45f92cb1
parent 224465 23e75fb7384e49cba2055a4bacd2225bfe641e2a
child 224467 e611dca6eb5c90edec64dbac5b6a981bc08f952e
push id3979
push userraliiev@mozilla.com
push dateMon, 13 Oct 2014 16:35:44 +0000
treeherdermozilla-beta@30f2cc610691 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1060993
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1060993 - Fix more bad implicit constructors in spellchecker; r=smaug
extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineChild.h
extensions/spellcheck/hunspell/src/mozHunspellDirProvider.h
extensions/spellcheck/src/mozInlineSpellChecker.h
extensions/spellcheck/src/mozPersonalDictionary.cpp
--- a/extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineChild.h
+++ b/extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineChild.h
@@ -9,17 +9,17 @@
 #include "mozSpellChecker.h"
 
 class mozSpellChecker;
 
 namespace mozilla {
 class RemoteSpellcheckEngineChild : public mozilla::PRemoteSpellcheckEngineChild
 {
 public:
-  RemoteSpellcheckEngineChild(mozSpellChecker *aOwner);
+  explicit RemoteSpellcheckEngineChild(mozSpellChecker *aOwner);
   ~RemoteSpellcheckEngineChild();
 
 private:
   mozSpellChecker *mOwner;
 };
 
 } //namespace mozilla
 
--- a/extensions/spellcheck/hunspell/src/mozHunspellDirProvider.h
+++ b/extensions/spellcheck/hunspell/src/mozHunspellDirProvider.h
@@ -55,17 +55,17 @@ private:
   ~mozHunspellDirProvider() {}
 
   class AppendingEnumerator MOZ_FINAL : public nsISimpleEnumerator
   {
   public:
     NS_DECL_ISUPPORTS
     NS_DECL_NSISIMPLEENUMERATOR
 
-    AppendingEnumerator(nsISimpleEnumerator* aBase);
+    explicit AppendingEnumerator(nsISimpleEnumerator* aBase);
 
   private:
     ~AppendingEnumerator() {}
 
     nsCOMPtr<nsISimpleEnumerator> mBase;
     nsCOMPtr<nsIFile>             mNext;
   };
 };
--- a/extensions/spellcheck/src/mozInlineSpellChecker.h
+++ b/extensions/spellcheck/src/mozInlineSpellChecker.h
@@ -30,17 +30,17 @@ class mozInlineSpellChecker;
 class mozInlineSpellResume;
 class InitEditorSpellCheckCallback;
 class UpdateCurrentDictionaryCallback;
 class mozInlineSpellResume;
 
 class mozInlineSpellStatus
 {
 public:
-  mozInlineSpellStatus(mozInlineSpellChecker* aSpellChecker);
+  explicit mozInlineSpellStatus(mozInlineSpellChecker* aSpellChecker);
 
   nsresult InitForEditorChange(EditAction aAction,
                                nsIDOMNode* aAnchorNode, int32_t aAnchorOffset,
                                nsIDOMNode* aPreviousNode, int32_t aPreviousOffset,
                                nsIDOMNode* aStartNode, int32_t aStartOffset,
                                nsIDOMNode* aEndNode, int32_t aEndOffset);
   nsresult InitForNavigation(bool aForceCheck, int32_t aNewPositionOffset,
                              nsIDOMNode* aOldAnchorNode, int32_t aOldAnchorOffset,
--- a/extensions/spellcheck/src/mozPersonalDictionary.cpp
+++ b/extensions/spellcheck/src/mozPersonalDictionary.cpp
@@ -44,17 +44,17 @@ NS_INTERFACE_MAP_BEGIN(mozPersonalDictio
   NS_INTERFACE_MAP_ENTRIES_CYCLE_COLLECTION(mozPersonalDictionary)
 NS_INTERFACE_MAP_END
 
 NS_IMPL_CYCLE_COLLECTION(mozPersonalDictionary, mEncoder)
 
 class mozPersonalDictionaryLoader MOZ_FINAL : public nsRunnable
 {
 public:
-  mozPersonalDictionaryLoader(mozPersonalDictionary *dict) : mDict(dict)
+  explicit mozPersonalDictionaryLoader(mozPersonalDictionary *dict) : mDict(dict)
   {
   }
 
   NS_IMETHOD Run()
   {
     mDict->SyncLoad();
 
     // Release the dictionary on the main thread