Bug 1520374 - Simplify error message for "Could not install python package"; r=aryx
authorGeoff Brown <gbrown@mozilla.com>
Fri, 18 Jan 2019 16:54:56 -0700
changeset 511665 c55210f1f837c270f0ab82d4ce563979b8a90a27
parent 511664 dd45dce4d3a9e37af40b36e631ffc9841817a3a0
child 511666 bfa40467bc83ffb2ab07dc8066e72eef75239513
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaryx
bugs1520374
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520374 - Simplify error message for "Could not install python package"; r=aryx Information like the pip path, package name, etc is useful for debugging, but not for bug classification: Let's try to collect all such failures in one "Could not install python package" bug. The full command line and retry attempt history is still retrievable from the log, for debugging purposes.
testing/mozharness/mozharness/base/python.py
--- a/testing/mozharness/mozharness/base/python.py
+++ b/testing/mozharness/mozharness/base/python.py
@@ -278,28 +278,26 @@ class VirtualenvMixin(object):
             command += [module_url]
 
         # If we're only installing a single requirements file, use
         # the file's directory as cwd, so relative paths work correctly.
         cwd = dirs['abs_work_dir']
         if not module and len(requirements) == 1:
             cwd = os.path.dirname(requirements[0])
 
-        quoted_command = subprocess.list2cmdline(command)
         # Allow for errors while building modules, but require a
         # return status of 0.
         self.retry(
             self.run_command,
             # None will cause default value to be used
             attempts=1 if optional else None,
             good_statuses=(0,),
             error_level=WARNING if optional else FATAL,
             error_message=(
-                'Could not install python package: '
-                + quoted_command + ' failed after %(attempts)d tries!'
+                'Could not install python package: failed all attempts.'
             ),
             args=[command, ],
             kwargs={
                 'error_list': VirtualenvErrorList,
                 'cwd': cwd,
                 'env': env,
                 # WARNING only since retry will raise final FATAL if all
                 # retry attempts are unsuccessful - and we only want