Bug 1124542 - WebrtcGmpVideoDecoder shouldn't crash when GMP completion callbacks are received. r=rjesup, a=lmandel
authorMatthew Gregan <kinetik@flim.org>
Wed, 21 Jan 2015 20:26:00 +1300
changeset 250433 c54687cb7086
parent 250432 caf324dbb13f
child 250434 5598a289b442
push id4589
push userryanvm@gmail.com
push date2015-03-19 02:20 +0000
treeherdermozilla-beta@d76c709556bb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrjesup, lmandel
bugs1124542
milestone37.0
Bug 1124542 - WebrtcGmpVideoDecoder shouldn't crash when GMP completion callbacks are received. r=rjesup, a=lmandel
media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h
--- a/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h
+++ b/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h
@@ -133,25 +133,22 @@ public:
     MOZ_CRASH();
   }
 
   virtual void ReceivedDecodedFrame(const uint64_t aPictureId) MOZ_OVERRIDE {
     MOZ_CRASH();
   }
 
   virtual void InputDataExhausted() MOZ_OVERRIDE {
-    MOZ_CRASH();
   }
 
   virtual void DrainComplete() MOZ_OVERRIDE {
-    MOZ_CRASH();
   }
 
   virtual void ResetComplete() MOZ_OVERRIDE {
-    MOZ_CRASH();
   }
 
   virtual void Error(GMPErr aError) MOZ_OVERRIDE {
   }
 
 private:
   virtual int32_t InitDecode_g(const webrtc::VideoCodec* aCodecSettings,
                                int32_t aNumberOfCores);