Bug 896032: Don't bother capturing return value from CallGetService in nsGtkKeyUtils.cpp, since we don't use it. r=smontagu
authorDaniel Holbert <dholbert@cs.stanford.edu>
Sun, 21 Jul 2013 15:53:53 -0700
changeset 151675 c525538afb69590f425ab6db1a8ad70cc88ccf04
parent 151674 6bcfc7a6eff08e47f56153c7213e880a68b062ed
child 151676 bb2316d853d66f51808c8c506f974784e851fbe7
push id2859
push userakeybl@mozilla.com
push dateMon, 16 Sep 2013 19:14:59 +0000
treeherdermozilla-beta@87d3c51cd2bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmontagu
bugs896032
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 896032: Don't bother capturing return value from CallGetService in nsGtkKeyUtils.cpp, since we don't use it. r=smontagu
widget/gtk2/nsGtkKeyUtils.cpp
--- a/widget/gtk2/nsGtkKeyUtils.cpp
+++ b/widget/gtk2/nsGtkKeyUtils.cpp
@@ -544,17 +544,17 @@ KeymapWrapper::OnKeysChanged(GdkKeymap *
                "This instance must be the singleton instance");
 
     // We cannot reintialize here becasue we don't have GdkWindow which is using
     // the GdkKeymap.  We'll reinitialize it when next GetInstance() is called.
     sInstance->mInitialized = false;
 
     // Reset the bidi keyboard settings for the new GdkKeymap
     if (!sBidiKeyboard) {
-        nsresult rv = CallGetService("@mozilla.org/widget/bidikeyboard;1", &sBidiKeyboard);
+        CallGetService("@mozilla.org/widget/bidikeyboard;1", &sBidiKeyboard);
     }
     if (sBidiKeyboard) {
         sBidiKeyboard->Reset();
     }
 }
 
 /* static */ guint
 KeymapWrapper::GetCurrentModifierState()