Bug 1547929 - [Tablet] Make default browser option not displayed on top of the Settings Menu; r=petru
authordiana.iacos <diana.iacos@softvision.ro>
Thu, 09 May 2019 10:23:25 +0000
changeset 532015 c3b634b55fb904e0e47c6081396e669297c18026
parent 532014 d7741d7e9b2c721515320e21dcbc6a8852ce2b09
child 532016 c78bb9fab197cb3120ca2704c72b2edf1ddccb49
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspetru
bugs1547929
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1547929 - [Tablet] Make default browser option not displayed on top of the Settings Menu; r=petru Differential Revision: https://phabricator.services.mozilla.com/D30468
mobile/android/app/src/main/res/xml-v11/preference_headers.xml
mobile/android/app/src/main/res/xml/preferences_general_tablet.xml
--- a/mobile/android/app/src/main/res/xml-v11/preference_headers.xml
+++ b/mobile/android/app/src/main/res/xml-v11/preference_headers.xml
@@ -54,22 +54,15 @@
     <header android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment"
         android:title="@string/pref_clear_private_data_now"
         android:id="@+id/pref_header_clear_private_data">
         <extra android:name="resource"
             android:value="preferences_privacy_clear_tablet"/>
     </header>
 
     <header android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment"
-        android:title="@string/pref_default_browser"
-        android:id="@+id/pref_header_default_browser">
-        <extra android:name="resource"
-            android:value="preferences_default_browser_tablet"/>
-    </header>
-
-    <header android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment"
             android:title="@string/pref_header_vendor"
             android:id="@+id/pref_header_vendor">
         <extra android:name="resource"
                android:value="preferences_vendor"/>
     </header>
 
 </preference-headers>
--- a/mobile/android/app/src/main/res/xml/preferences_general_tablet.xml
+++ b/mobile/android/app/src/main/res/xml/preferences_general_tablet.xml
@@ -10,16 +10,22 @@
 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
                   android:title="@string/pref_category_general"
                   android:enabled="false">
 
     <org.mozilla.gecko.preferences.SyncPreference android:key="android.not_a_preference.sync"
                                                   android:title="@string/pref_sync"
                                                   android:persistent="false" />
 
+    <org.mozilla.gecko.preferences.DefaultBrowserPreference
+            android:key="android.not_a_preference.default_browser.link"
+            android:title="@string/pref_default_browser"
+            android:persistent="false"
+            url="https://support.mozilla.org/kb/make-firefox-default-browser-android?utm_source=inproduct&amp;utm_medium=settings&amp;utm_campaign=mobileandroid"/>
+
     <PreferenceScreen android:key="android.not_a_preference.general_home"
                       android:title="@string/pref_category_home"
                       android:summary="@string/pref_category_home_summary"
                       android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment" >
             <extra android:name="resource"
                    android:value="preferences_home" />
     </PreferenceScreen>