Bug 1397754 - Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. r=Gijs
authorMike de Boer <mdeboer@mozilla.com>
Mon, 11 Sep 2017 17:30:52 +0200
changeset 429548 c33c05b5d47d306a2a7eeeca4a17aa48aa14f35f
parent 429547 3b7add087f2b2fe1c489350af9c3ffe1fb21fb2a
child 429549 3f4c7db71dc24cd682dac0e3612c464ee1c0c029
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1397754
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1397754 - Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. r=Gijs The combined button widget issue only appeared on OSX. MozReview-Commit-ID: 3T05WDUCPrQ
browser/themes/osx/customizableui/panelUI.css
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/themes/osx/customizableui/panelUI.css
+++ b/browser/themes/osx/customizableui/panelUI.css
@@ -11,16 +11,20 @@
 .restoreallitem > .toolbarbutton-icon {
   display: none;
 }
 
 .subviewbutton {
   padding-inline-start: 18px;
 }
 
+photonpanelmultiview .toolbaritem-combined-buttons > label {
+  padding-inline-start: 42px; /* 18px toolbarbutton padding + 16px icon + 8px label padding start */
+}
+
 .subviewbutton[checked="true"] {
   background-position: top 7px left 4px;
 }
 
 .subviewbutton[checked="true"]:-moz-locale-dir(rtl) {
   background-position: top 7px right 4px;
 }
 
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -824,23 +824,23 @@ toolbaritem[cui-areatype="menu-panel"][s
 #appMenu-fxa-container[fxastatus="signedin"] > #appMenu-fxa-status > #appMenu-fxa-label > .toolbarbutton-icon,
 #appMenu-fxa-container:not([fxastatus="signedin"]) > toolbarseparator,
 #appMenu-fxa-container:not([fxastatus="signedin"]) > #appMenu-fxa-icon,
 #appMenu-fxa-container:not([fxastatus="signedin"]) > #appMenu-fxa-status > #appMenu-fxa-avatar {
   display: none;
 }
 
 #appMenu-fxa-container[fxastatus="signedin"] > #appMenu-fxa-status > #appMenu-fxa-label {
-  /* 12px space before the avatar, then 16px for the avatar */
-  padding-inline-start: 28px;
-  margin-inline-start: -28px;
+  /* 18px space before the avatar, then 16px for the avatar */
+  padding-inline-start: 34px;
+  margin-inline-start: -34px;
 }
 
 #appMenu-fxa-container[fxastatus="signedin"] > #appMenu-fxa-status > #appMenu-fxa-avatar {
-  margin-inline-start: 12px;
+  margin-inline-start: 18px;
 }
 
 /* Error states */
 #appMenu-fxa-container[fxastatus="unverified"] > #appMenu-fxa-status > #appMenu-fxa-label,
 #appMenu-fxa-container[fxastatus="login-failed"] > #appMenu-fxa-status > #appMenu-fxa-label {
   list-style-image: url(chrome://browser/skin/warning.svg);
   -moz-image-region: rect(0, 16px, 16px, 0);
 }