Bug 1082970 - Sync no longer shows login failed notification bar on user-initiated sync. r=mhammond, a=sledru
authorAlan K <akligman@mozilla.com>
Wed, 15 Oct 2014 19:23:00 +0200
changeset 233392 c2d9b859f345dfc90a9e6164abb6b98d2d2217ca
parent 233391 64eb7cf0d472c90bff8ff2b1ab705739d8863eeb
child 233393 745747d29111f0cb57cac4c7185860724a77c033
push id4187
push userbhearsum@mozilla.com
push dateFri, 28 Nov 2014 15:29:12 +0000
treeherdermozilla-beta@f23cc6a30c11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhammond, sledru
bugs1082970
milestone35.0a2
Bug 1082970 - Sync no longer shows login failed notification bar on user-initiated sync. r=mhammond, a=sledru
browser/base/content/browser-syncui.js
--- a/browser/base/content/browser-syncui.js
+++ b/browser/base/content/browser-syncui.js
@@ -282,19 +282,18 @@ let gSyncUI = {
   openServerStatus: function () {
     let statusURL = Services.prefs.getCharPref("services.sync.statusURL");
     window.openUILinkIn(statusURL, "tab");
   },
 
   // Commands
   doSync: function SUI_doSync() {
     let needsSetup = this._needsSetup();
-    let loginFailed = this._loginFailed();
 
-    if (!(loginFailed || needsSetup)) {
+    if (!needsSetup) {
       setTimeout(function () Weave.Service.errorHandler.syncAndReportErrors(), 0);
     }
 
     Services.obs.notifyObservers(null, "cloudsync:user-sync", null);
   },
 
   handleToolbarButton: function SUI_handleStatusbarButton() {
     if (this._needsSetup())