Bug 1532435 - Skip junit inputConnection test on debug only, to save lots of time; r=snorp
authorGeoff Brown <gbrown@mozilla.com>
Wed, 13 Mar 2019 15:26:36 +0000
changeset 521716 c2beaac71305
parent 521715 69f7e56e68bc
child 521717 226ec6ce41c4
push id10867
push userdvarga@mozilla.com
push dateThu, 14 Mar 2019 15:20:45 +0000
treeherdermozilla-beta@abad13547875 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1532435
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1532435 - Skip junit inputConnection test on debug only, to save lots of time; r=snorp Disabling inputConnection on debug saves about 15 minutes of time, which helps us avoid the timeouts seen in this bug. It continues running on opt, where it runs much faster. Differential Revision: https://phabricator.services.mozilla.com/D23254
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TextInputDelegateTest.kt
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TextInputDelegateTest.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TextInputDelegateTest.kt
@@ -294,16 +294,19 @@ class TextInputDelegateTest : BaseSessio
     private fun assertTextAndSelectionAt(message: String, ic: InputConnection,
                                          expected: String, value: Int,
                                          checkGecko: Boolean = true) =
             assertTextAndSelection(message, ic, expected, value, value, checkGecko)
 
     @ReuseSession(false) // Test is only reliable on automation when not reusing session.
     @WithDisplay(width = 512, height = 512) // Child process updates require having a display.
     @Test fun inputConnection() {
+        // too slow on debug
+        assumeThat(sessionRule.env.isDebugBuild, equalTo(false))
+
         mainSession.textInput.view = View(InstrumentationRegistry.getTargetContext())
 
         mainSession.loadTestPath(INPUTS_PATH)
         mainSession.waitForPageStop()
 
         textContent = "foo"
         mainSession.evaluateJS("$('$id').focus()")
         mainSession.waitUntilCalled(GeckoSession.TextInputDelegate::class, "restartInput")