Bug 1125940 - File should not unlink FileImpl. r=khuey, a=lmandel
authorAndrea Marchesini <amarchesini@mozilla.com>
Thu, 19 Feb 2015 18:31:32 +0100
changeset 250140 c16968de534c
parent 250139 09b2c7fed10f
child 250141 191548235ce3
push id4513
push userryanvm@gmail.com
push date2015-03-02 19:36 +0000
treeherdermozilla-beta@824656d7ad0d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskhuey, lmandel
bugs1125940
milestone37.0
Bug 1125940 - File should not unlink FileImpl. r=khuey, a=lmandel
dom/base/File.cpp
--- a/dom/base/File.cpp
+++ b/dom/base/File.cpp
@@ -124,24 +124,21 @@ nsresult DataOwnerAdapter::Create(DataOw
 }
 
 ////////////////////////////////////////////////////////////////////////////
 // mozilla::dom::File implementation
 
 NS_IMPL_CYCLE_COLLECTION_CLASS(File)
 
 NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(File)
-  // No unlink for mImpl bacause FileImpl is not CC-able.
-  tmp->mImpl = nullptr;
   NS_IMPL_CYCLE_COLLECTION_UNLINK(mParent)
   NS_IMPL_CYCLE_COLLECTION_UNLINK_PRESERVED_WRAPPER
 NS_IMPL_CYCLE_COLLECTION_UNLINK_END
 
 NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(File)
-  // No traverse for mImpl bacause FileImpl is not CC-able.
   NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mParent)
   NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS
 NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
 
 NS_IMPL_CYCLE_COLLECTION_TRACE_BEGIN(File)
   NS_IMPL_CYCLE_COLLECTION_TRACE_PRESERVED_WRAPPER
 NS_IMPL_CYCLE_COLLECTION_TRACE_END