Bug 1448224 [wpt PR 10150] - Don't adjust the NavigationTimings on redirects, a=testonly
authorKinuko Yasuda <kinuko@chromium.org>
Mon, 09 Apr 2018 18:15:05 +0000
changeset 467189 c114530770d67bef7f077c0102ec8627b203c250
parent 467188 2727b165f16ccc4ee1830e9eb76af9da0daf1fe4
child 467190 a9a6d7d5e674c7010a1a58e68961cee651a57f27
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1448224, 10150, 813889, 974673, 546001
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1448224 [wpt PR 10150] - Don't adjust the NavigationTimings on redirects, a=testonly Automatic update from web-platform-testsDon't adjust the NavigationTimings on redirects We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(), shouldn't update in each AddRedirect() (which is called in a batch way after all the redirects are handled in the browser process with PlzNavigate, adjusting timings there with current timestamp is totally wrong) R=ksakamoto,arthursonzogni Bug: 813889 Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b Reviewed-on: https://chromium-review.googlesource.com/974673 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#546001} wpt-commits: c32afde8ec7f0e10b5b5f27c4907095c37303e71 wpt-pr: 10150 wpt-commits: c32afde8ec7f0e10b5b5f27c4907095c37303e71 wpt-pr: 10150
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/navigation-timing/test_timing_server_redirect.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -576492,17 +576492,17 @@
    "c6aed0cb03b941e0b8c62a0b086099759b4b25ef",
    "testharness"
   ],
   "navigation-timing/test_timing_reload.html": [
    "57ba3573d672dbbc60695d049dec39efd5e1feb9",
    "testharness"
   ],
   "navigation-timing/test_timing_server_redirect.html": [
-   "10b7f221c4667e92a993f0aae70820a95ea445aa",
+   "e08cd61d0e373b0ba04e00d429b3c607df8d2fd4",
    "testharness"
   ],
   "navigation-timing/test_timing_xserver_redirect.html": [
    "a08120e4302c51307fa97de3d521c85c82adb53f",
    "testharness"
   ],
   "navigation-timing/test_unique_performance_objects.html": [
    "b9d933d6a33eabc0b9c9f856c91b802677fa1094",
--- a/testing/web-platform/tests/navigation-timing/test_timing_server_redirect.html
+++ b/testing/web-platform/tests/navigation-timing/test_timing_server_redirect.html
@@ -27,16 +27,17 @@
                         'timing.navigation.type is TYPE_NAVIGATE');
                 test_equals(performanceNamespace.navigation.redirectCount, 1, 'navigation.redirectCount == 1 on an server redirected navigation');
 
                 test_timing_greater_than('navigationStart', 0);
 
                 test_timing_order('redirectStart', 'navigationStart');
                 test_timing_order('redirectEnd', 'redirectStart');
                 test_timing_order('fetchStart', 'redirectEnd');
+                test_timing_order('requestStart', 'fetchStart');
             }
         </script>
 
     </head>
     <body>
         <h1>Description</h1>
         <p>This test validates the values of the window.performance.redirectCount and the
            window.performance.timing.redirectStart/End times for a same-origin server side redirect navigation.</p>