Bug 1275582 - TSan: data race security/nss/lib/freebl/sha_fast.c:176 SHA1_End. r=dkeeler a=sylvestre
authorJulian Seward <jseward@acm.org>
Mon, 30 May 2016 15:25:52 +0200
changeset 333197 bf4d710c80531aa2c170f076716513e69206b05d
parent 333196 76d7c6af162c72bbc0b8fb4be01159408b9f2ff4
child 333198 e62f5236debc0f72b222ae6885e706f1f07af181
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdkeeler, sylvestre
bugs1275582
milestone48.0a2
Bug 1275582 - TSan: data race security/nss/lib/freebl/sha_fast.c:176 SHA1_End. r=dkeeler a=sylvestre
security/pkix/lib/pkixocsp.cpp
--- a/security/pkix/lib/pkixocsp.cpp
+++ b/security/pkix/lib/pkixocsp.cpp
@@ -760,17 +760,17 @@ CertID(Reader& input, const Context& con
 //                          -- bits] in the responder's certificate)
 static Result
 MatchKeyHash(TrustDomain& trustDomain, Input keyHash,
              const Input subjectPublicKeyInfo, /*out*/ bool& match)
 {
   if (keyHash.GetLength() != SHA1_DIGEST_LENGTH)  {
     return Result::ERROR_OCSP_MALFORMED_RESPONSE;
   }
-  static uint8_t hashBuf[SHA1_DIGEST_LENGTH];
+  uint8_t hashBuf[SHA1_DIGEST_LENGTH];
   Result rv = KeyHash(trustDomain, subjectPublicKeyInfo, hashBuf,
                       sizeof hashBuf);
   if (rv != Success) {
     return rv;
   }
   Input computed(hashBuf);
   match = InputsAreEqual(computed, keyHash);
   return Success;