Bug 1523851 - Remove AC_PROG_GCC_TRADITIONAL test. r=froydnj
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 30 Jan 2019 14:39:01 +0000
changeset 514100 bf3ead324b247c2830a12d28705af5f837bf1e8d
parent 514099 9e6b8fb9b9ff9653583bc6b5dedc96103a036ee7
child 514101 697b9cab7789cb0b5701a636efbecbf24f211ad4
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1523851
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523851 - Remove AC_PROG_GCC_TRADITIONAL test. r=froydnj While not related, it turns out this test was opted in by ourselves, while it's practically useless. Recent autoconf documentation says it's obsolescent, and even autoconf 2.13 documentation said with "recent versions of the GNU C compiler", the issue it's detecting "is becoming a less prevalent problem". Recent as of 20 years ago. Differential Revision: https://phabricator.services.mozilla.com/D18054
build/moz.configure/toolchain.configure
js/src/old-configure.in
old-configure.in
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -1184,17 +1184,16 @@ def compiler(language, host_or_target, c
         add_old_configure_assignment('ac_cv_prog_%s' % var, depends_if(valid_compiler)(
             lambda x: list(x.wrapper) + [x.compiler] + list(x.flags)))
         # We check that it works in python configure already.
         add_old_configure_assignment('ac_cv_prog_%s_works' % var.lower(), 'yes')
         gcc_like = depends(valid_compiler.type)(lambda x: 'yes' if x in ('gcc', 'clang') else 'no')
         add_old_configure_assignment('ac_cv_prog_%s_g' % var.lower(), gcc_like)
         if language == 'C':
             add_old_configure_assignment('ac_cv_prog_gcc', gcc_like)
-            add_old_configure_assignment('ac_cv_prog_gcc_traditional', 'no')
         if language == 'C++':
             add_old_configure_assignment('ac_cv_prog_gxx', gcc_like)
 
 
     # Set CC_TYPE/CC_VERSION/HOST_CC_TYPE/HOST_CC_VERSION to allow
     # old-configure to do some of its still existing checks.
     if language == 'C':
         set_config(
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -995,17 +995,16 @@ then
 
 	esac
     LDFLAGS="${_PTHREAD_LDFLAGS} ${LDFLAGS}"
 fi
 
 
 dnl Checks for library functions.
 dnl ========================================================
-AC_PROG_GCC_TRADITIONAL
 AC_FUNC_MEMCMP
 AC_CHECK_FUNCS([getc_unlocked _getc_nolock gmtime_r localtime_r pthread_getname_np pthread_get_name_np])
 
 dnl check for clock_gettime(), the CLOCK_MONOTONIC clock
 dnl avoid this on Darwin, since depending on your system config, we may think
 dnl it exists but it really doesn't
 case "$OS_TARGET" in
 Darwin)
--- a/old-configure.in
+++ b/old-configure.in
@@ -1270,17 +1270,16 @@ then
     LDFLAGS="${_PTHREAD_LDFLAGS} ${LDFLAGS}"
     AC_SUBST(MOZ_USE_PTHREADS)
     MOZ_CHECK_HEADERS(pthread.h)
 fi
 
 
 dnl Checks for library functions.
 dnl ========================================================
-AC_PROG_GCC_TRADITIONAL
 AC_FUNC_MEMCMP
 AC_CHECK_FUNCS(stat64 lstat64 truncate64 statvfs64 statvfs statfs64 statfs getpagesize gmtime_r localtime_r arc4random arc4random_buf mallinfo gettid lchown setpriority strerror syscall)
 
 dnl check for clock_gettime(), the CLOCK_MONOTONIC clock
 dnl avoid this on Darwin, since depending on your system config, we may think
 dnl it exists but it really doesn't
 case "$OS_TARGET" in
 Darwin)