Bug 1639144 - Fix the dropdown arrow in the profiler popup; r=julienw
authorGreg Tatum <gtatum@mozilla.com>
Wed, 03 Jun 2020 19:28:43 +0000
changeset 597848 becb52cac8b505e27e1a1f1f42a33b97aa8f49f2
parent 597847 63d2be009e8d39ed00866c3299d0eae19cd736bb
child 597849 5e2370099c2a7b4f29b2fdb5c5d00b66157324e8
push id13310
push userffxbld-merge
push dateMon, 29 Jun 2020 14:50:06 +0000
treeherdermozilla-beta@15a59a0afa5c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjulienw
bugs1639144
milestone79.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1639144 - Fix the dropdown arrow in the profiler popup; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D77479
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -2156,16 +2156,17 @@ panelview:not([mainview]) #PanelUI-whats
 #PanelUI-profiler-info button:focus {
   box-shadow: 0 0 0 2px #fff, 0 0 0 6px rgba(255, 255, 255, 0.3);
   border-radius: 2px;
   text-decoration: none;
 }
 
 #PanelUI-profiler-presets {
   -moz-appearance: none;
+  position: relative; /* Ensure there is a stacking context for the dropdown arrow. */
   width: 100%;
   min-height: 24px;
   background-color: #EDEDF0;
   color: inherit !important;
   border: 1px solid transparent;
   border-radius: 2px;
   font-weight: 400;
   padding-inline: 4px;
@@ -2204,24 +2205,34 @@ panelview:not([mainview]) #PanelUI-whats
   padding-block: 0.2em;
 }
 
 #PanelUI-profiler-presets menuitem[_moz-menuactive] {
   color: #fff;
   background-color: #0060DF;
 }
 
-/* The dropmarker is generated by the menulist element */
-#PanelUI-profiler-presets dropmarker {
-  -moz-appearance: none;
+#PanelUI-profiler-presets::after {
+  width: 12px;
+  height: 12px;
+  position: absolute;
   display: block;
+  content: "";
   margin-block-start: 5px;
   -moz-context-properties: fill;
-  list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
   fill: currentColor;
+  background: url("chrome://global/skin/icons/arrow-dropdown-12.svg") center center no-repeat;
+}
+
+#PanelUI-profiler-presets:-moz-locale-dir(ltr)::after {
+  right: 22px;
+}
+
+#PanelUI-profiler-presets:-moz-locale-dir(rtl)::after {
+  left: 22px;
 }
 
 #PanelUI-profiler-content-custom-button {
   -moz-appearance: none;
   margin: 0;
   color: #0046A4;
   font-size: 12px;
   cursor: pointer;