Bug 1472806 - fix missing typename warning in COMPtrHolder.h; r=aklotz
authorNathan Froyd <froydnj@mozilla.com>
Tue, 03 Jul 2018 17:04:26 -0400
changeset 480020 be73fc773100823d69c1330bbcb8f5e593f65e9d
parent 480019 53e44a1beb93ae8caa523ccfd0e54400192f8aae
child 480021 f859daf8d8d9356eb2c51811d724403d56574639
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaklotz
bugs1472806
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472806 - fix missing typename warning in COMPtrHolder.h; r=aklotz MSVC permits the missing `typename` as an extension, whereas clang-cl warns. This is easy to fix, so let's fix the warning noise.
ipc/mscom/COMPtrHolder.h
--- a/ipc/mscom/COMPtrHolder.h
+++ b/ipc/mscom/COMPtrHolder.h
@@ -157,17 +157,17 @@ struct ParamTraits<mozilla::mscom::COMPt
   {
 #if defined(MOZ_CONTENT_SANDBOX)
     static const bool sIsStreamPreservationNeeded =
       XRE_IsParentProcess() && mozilla::GetEffectiveContentSandboxLevel() >= 3;
 #else
     const bool sIsStreamPreservationNeeded = false;
 #endif // defined(MOZ_CONTENT_SANDBOX)
 
-    paramType::EnvType env;
+    typename paramType::EnvType env;
 
     mozilla::mscom::ProxyStreamFlags flags = sIsStreamPreservationNeeded ?
          mozilla::mscom::ProxyStreamFlags::ePreservable :
          mozilla::mscom::ProxyStreamFlags::eDefault;
 
     mozilla::mscom::ProxyStream proxyStream(_IID, aParam.Get(), &env, flags);
     int bufLen;
     const BYTE* buf = proxyStream.GetBuffer(bufLen);