Bug 1187278 - Adjust tabContentStart for "scrollable tabs" on phones. r=mhaigh
authorSebastian Kaspari <s.kaspari@gmail.com>
Tue, 28 Jul 2015 19:20:02 +0200
changeset 287149 be626b9af2fd4faae6d7be2d2f3790d9c73d8231
parent 287072 39fc38df750d11a792cd3cf2e10e712074588576
child 287150 d59e6ed60e5aa0437c91f01a1bc0a8033c319f78
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1187278
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1187278 - Adjust tabContentStart for "scrollable tabs" on phones. r=mhaigh
mobile/android/base/resources/layout/home_pager.xml
mobile/android/base/resources/values-large-v11/dimens.xml
mobile/android/base/resources/values/dimens.xml
--- a/mobile/android/base/resources/layout/home_pager.xml
+++ b/mobile/android/base/resources/layout/home_pager.xml
@@ -13,11 +13,11 @@
                                   android:layout_height="match_parent"
                                   android:background="@android:color/white">
 
     <org.mozilla.gecko.home.TabMenuStrip android:layout_width="match_parent"
                                          android:layout_height="@dimen/tabs_strip_height"
                                          android:background="@color/about_page_header_grey"
                                          android:layout_gravity="top"
                                          gecko:strip="@drawable/home_tab_menu_strip"
-                                         gecko:tabContentStart="72dp" />
+                                         gecko:tabContentStart="@dimen/tab_strip_content_start" />
 
 </org.mozilla.gecko.home.HomePager>
--- a/mobile/android/base/resources/values-large-v11/dimens.xml
+++ b/mobile/android/base/resources/values-large-v11/dimens.xml
@@ -26,9 +26,11 @@
     <dimen name="reading_list_row_height">96dp</dimen>
     <dimen name="reading_list_row_padding_right">15dp</dimen>
 
     <dimen name="overlay_prompt_container_width">360dp</dimen>
 
     <!-- Should be closer to 0.83 (140/168) but various roundings mean that 0.9 works better -->
     <item name="thumbnail_aspect_ratio" format="float" type="dimen">0.9</item>
 
+    <item name="tab_strip_content_start" type="dimen">72dp</item>
+
 </resources>
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -210,9 +210,11 @@
 
     <!-- This is a 4:7 ratio (as per UX decision). -->
     <item name="thumbnail_aspect_ratio" format="float" type="dimen">0.571</item>
 
     <!-- http://blog.danlew.net/2015/01/06/handling-android-resources-with-non-standard-formats/ -->
     <item name="match_parent" type="dimen">-1</item>
     <item name="wrap_content" type="dimen">-2</item>
 
+    <item name="tab_strip_content_start" type="dimen">12dp</item>
+
 </resources>