Bug 1455176: Follow-up: Fix devtools bustage in more straggler tests that still use Task global. r=bustage
authorKris Maglione <maglione.k@gmail.com>
Thu, 19 Apr 2018 17:02:49 -0700
changeset 468251 be575e9c66e18816eb90884b718342906c00f548
parent 468250 9aa58b68a002add2db9bf9ccd8966616b384bf72
child 468252 ecd4ccf11c070978542a43aab32fbe558f703f51
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1455176
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455176: Follow-up: Fix devtools bustage in more straggler tests that still use Task global. r=bustage MozReview-Commit-ID: 9GzKdRlUXup
devtools/client/framework/test/browser_target_support.js
devtools/client/framework/test/browser_toolbox_tool_ready.js
devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js
--- a/devtools/client/framework/test/browser_target_support.js
+++ b/devtools/client/framework/test/browser_target_support.js
@@ -56,17 +56,17 @@ function test() {
 
   getChromeActors((client, response) => {
     let options = {
       form: response,
       client: client,
       chrome: true
     };
 
-    TargetFactory.forRemoteTab(options).then(Task.async(testTarget).bind(null, client));
+    TargetFactory.forRemoteTab(options).then(testTarget.bind(null, client));
   });
 }
 
 function close(target, client) {
   target.on("close", () => {
     ok(true, "Target was closed");
     finish();
   });
--- a/devtools/client/framework/test/browser_toolbox_tool_ready.js
+++ b/devtools/client/framework/test/browser_toolbox_tool_ready.js
@@ -26,19 +26,19 @@ function performChecks(target) {
       ok(panel.isReady, toolId + " panel should be ready");
     }
 
     await toolbox.destroy();
   })();
 }
 
 function test() {
-  Task.spawn(async function() {
+  (async function() {
     toggleAllTools(true);
     let tab = await addTab("about:blank");
     let target = TargetFactory.forTab(tab);
     await target.makeRemote();
     await performChecks(target);
     gBrowser.removeCurrentTab();
     toggleAllTools(false);
     finish();
-  }, console.error);
+  })();
 }
--- a/devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js
+++ b/devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js
@@ -83,17 +83,17 @@ function getTarget(client) {
     });
     deferred.resolve(target);
   });
 
   return deferred.promise;
 }
 
 function test() {
-  Task.spawn(async function() {
+  (async function() {
     toggleAllTools(true);
     await addTab("about:blank");
 
     let client = await getClient();
     let target = await getTarget(client);
     await runTools(target);
 
     // Actor fronts should be destroyed now that the toolbox has closed, but
@@ -117,10 +117,10 @@ function test() {
         ok(false, "Front for " + actor + " still held in pool!");
       }
     }
 
     gBrowser.removeCurrentTab();
     DebuggerServer.destroy();
     toggleAllTools(false);
     finish();
-  }, console.error);
+  })();
 }