Bug 1494828 [wpt PR 13249] - Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again", a=testonly
authorWenzhao (Colin) Zang <wzang@chromium.org>
Fri, 05 Oct 2018 14:20:37 +0000
changeset 495785 bda73f529c5d3386bc683c08b6fd9d0b35aeb9be
parent 495784 273720035c7a785b27e30787237f47c2fee3810e
child 495786 a9d89c01bd9856999486a9937d947554a0232489
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1494828, 13249, 890100, 596743, 1246730, 594752, 1250207, 594936
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1494828 [wpt PR 13249] - Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again", a=testonly Automatic update from web-platform-testsRevert "[css-flexbox] Apply min-height: auto to nested flexboxes again" This reverts commit 35b382aa26d503c46963fdd6fa41bffe42cc7074. Reason for revert: crbug.com/890100 Original change's description: > [css-flexbox] Apply min-height: auto to nested flexboxes again > > To avoid the previous regression (see analysis in bug), we force > layout in the case where we otherwise would get an outdated result. > > Bug: 596743 > Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756 > Reviewed-on: https://chromium-review.googlesource.com/1246730 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594752} TBR=cbiesinger@chromium.org,eae@chromium.org,mstensho@chromium.org Change-Id: I8ef1e6a3e5f191c495c0b36d32366de3f0323a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 596743 Reviewed-on: https://chromium-review.googlesource.com/1250207 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594936} -- wpt-commits: 36634cbcf3253dfe8d220990a27ad4eeebf8ec2f wpt-pr: 13249
testing/web-platform/tests/css/css-flexbox/flex-minimum-height-flex-items-009.html
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-flexbox/flex-minimum-height-flex-items-009.html
+++ /dev/null
@@ -1,62 +0,0 @@
-<!DOCTYPE html>
-<title>Tests correct handling of min-height: auto with dynamic changes</title>
-<link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#min-size-auto" title="4.5. Implied Minimum Size of Flex Items" />
-<link rel="author" title="Google Inc." href="http://www.google.com/">
-<link href="support/flexbox.css" rel="stylesheet">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script src="/resources/check-layout-th.js"></script>
-<style>
-.container {
-  height: 300px;
-  outline: 2px solid black;
-}
-
-.inner
-{
-  width: 400px;
-  flex: 1;
-  background-color: green;
-}
-#container2 .flexbox > * { flex-basis: 0; }
-#container2 .column > * { flex-basis: auto; }
-</style>
-<script>
-function change() {
-  var container = document.getElementById('container');
-  container.offsetHeight;
-  container.style.height = '80px';
-  container = document.getElementById('container2');
-  container.offsetHeight;
-  container.style.height = '80px';
-  checkLayout('.container');
-}
-</script>
-<body onload="change()">
-<p>Green rectangle should be entirely within the black rectangle</p>
-<div id="log"></div>
-<div id="container" class="container">
-  <div class="flexbox column" style="height: 100%;">
-    <div class="flexbox flex-one">
-        <div class="flexbox column">
-          <div class="flexbox column flex-one">
-            <div class="inner" data-expected-height="80">
-            </div>
-          </div>
-        </div>
-    </div>
-  </div>
-</div>
-
-<div id="container2" class="container">
-  <div class="flexbox column" style="height: 100%;">
-    <div class="flexbox flex-one">
-        <div class="flexbox column">
-          <div class="flexbox column flex-one">
-            <div class="inner" data-expected-height="80">
-            </div>
-          </div>
-        </div>
-    </div>
-  </div>
-</div>